Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dev variables dumi no work #163

Merged
merged 6 commits into from
May 6, 2020
Merged

Conversation

xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Apr 30, 2020

使用一些环境变量之后,api 的 cwd 是动态的,比如使用 APP_ROOT=dumi dumi dev
正确的 cwd 是 /Users/xiaohuoni/Desktop/cra/dumi-demo-cra/dumi
dumi 中使用 process.cwd() 获取到的是 /Users/xiaohuoni/Desktop/cra/dumi-demo-cra

Close: #121
Close: #161

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #163 into master will increase coverage by 0.06%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   49.52%   49.59%   +0.06%     
==========================================
  Files          73       73              
  Lines        1462     1464       +2     
  Branches      499      502       +3     
==========================================
+ Hits          724      726       +2     
  Misses        734      734              
  Partials        4        4              
Impacted Files Coverage Δ
packages/preset-dumi/src/plugins/core.ts 0.00% <0.00%> (ø)
packages/preset-dumi/src/routes/getRouteConfig.ts 0.00% <0.00%> (ø)
...es/preset-dumi/src/routes/getRouteConfigFromDir.ts 100.00% <100.00%> (ø)
...ackages/preset-dumi/src/transformer/remark/yaml.ts 70.00% <100.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5f09a...0b01673. Read the comment docs.

@PeachScript PeachScript merged commit aedec97 into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-use-env-variables branch May 6, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

请问有方法在已有项目中添加 dumi 嘛? bug: 不能和create-react-app配套使用
2 participants