Skip to content

V8/Warn editor when deleting a media item that is in use#9118

Closed
dawoe wants to merge 101 commits intoumbraco:v8/item-trackingfrom
dawoe:v8/temp_8693
Closed

V8/Warn editor when deleting a media item that is in use#9118
dawoe wants to merge 101 commits intoumbraco:v8/item-trackingfrom
dawoe:v8/temp_8693

Conversation

@dawoe
Copy link
Contributor

@dawoe dawoe commented Oct 8, 2020

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #8693

Description

This PR introduces a warning to editors when they try to delete a media item or folder in the media section when the item or one of the underlying items of a folder is in use.

delete-warning

Note for reviewers

This PR builds on top of PR #9116 so it's recommend that that one is reviewed and merged first.

Steps to test

See steps for media in #9116. When you try to delete the item a warning is shown + information of the references.

dawoe added 13 commits October 8, 2020 10:27
@dawoe
Added API method to check for references in descendants
c15f07e
@dawoe
Added UI parts to show if a item has underlying items that are in use
7834c4d
@dawoe
Updated component to call api to check for usages in descendants
f351c8c
@dawoe
Refactored so loading state is updated when all promises are resolved
8dc4caf
@dawoe
Implement API method to check for usage in descendants
fc43d62
@dawoe
Don't show message that there are no referencese if one of the descen…
3b6421d 
…dants is in use
@dawoe
Added new service and repostiory method to check descendants in use f…
892462f 
…or performance reasons. Looping through the descendants and checking each one individually for references was terribly slow
@dawoe
Remove commented code in repository
3e00ae3
@dawoe
Added loading property to tracked references component
b0a543c
@dawoe
Added tracked references dialog to media delete dialog
c2debb4
@dawoe
Hide confirmation buttons until checking of referneces has been done
28dae0f
@dawoe
Don't show message that are no references in the delete dialog for me…
df06439 
…dia items
@dawoe
Added a nice warning for editor when trying to delete items that are …
d5f3e69 
…in use
@dawoe dawoe mentioned this pull request Oct 8, 2020
Closed
1 task
@dawoe dawoe mentioned this pull request Oct 9, 2020
Closed
1 task
@emmaburstow
Copy link
Contributor

emmaburstow commented Oct 12, 2020

Hey @dawoe

Thanks also for this 👍 We'll shout if we have questions,

Em

@nielslyngsoe
Copy link
Member

nielslyngsoe commented Oct 14, 2020

@dawoe YES YES YES! This is so great, thank you! :-D

nul800sebastiaan and others added 23 commits May 18, 2021 15:47
@nul800sebastiaan
New issue forms
0432636
@nul800sebastiaan
Update CONTRIBUTING.md
92cdf4e
@nul800sebastiaan
Update CONTRIBUTING.md
14558ae
@nielslyngsoe @madsrasmussen
#10274 Variant sorting should take into account that there might not …
017b56e 
…be any language (#10278) (#10284)

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
@nielslyngsoe @madsrasmussen @nul800sebastiaan
#10274 Variant sorting should take into account that there might not …
36c49b0 
…be any language (#10278)

* Variant sorting should take into account that there might not be any language available

* fix languages

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
(cherry picked from commit e19a598)
@mistyn8 @nul800sebastiaan
Update ModelsBuilderComposer.cs
7c2f956 
issue #10186

typo in IsExternalModelsBuilderInstalled -> Umbraco.ModelsBuider

(cherry picked from commit b783399)
@nul800sebastiaan
Merge branch 'v8/8.13' into v8/8.14
7b77d21 
# Conflicts:
#	src/SolutionInfo.cs
@nielslyngsoe @madsrasmussen @nul800sebastiaan
#10274 Variant sorting should take into account that there might not …
9730a18 
…be any language (#10278) (#10284)

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
(cherry picked from commit 017b56e)
@nul800sebastiaan
Update CONTRIBUTING.md
779c94c
@nul800sebastiaan
Update CONTRIBUTING.md
a2c461b
@nul800sebastiaan
Bump version to 8.13.1
3f596e2
@bjarnef
Add option to remove/cancel added crops (#10267)
710ecf2 
* Add option to remove/cancel added crops

* Move vm functions to top

* Only show cancel button for empty/new crop
@nul800sebastiaan
Fix invalid XML
9bf0174
@AndyButland @nul800sebastiaan
Fixed issue with data types not being cleared in cache refresh operat…
71a1817 
…ions.
@AndyButland @nul800sebastiaan
Fixed issue with data types not being cleared in cache refresh operat…
12328ba 
…ions.

(cherry picked from commit 71a1817)
@nul800sebastiaan
Can't use optimized version of this method call until 8.14
008480a
@nul800sebastiaan
Merge branch 'v8/8.13' into v8/8.14
0a9325c 
# Conflicts:
#	src/SolutionInfo.cs
@nul800sebastiaan
Merge branch 'v8/8.14' into v8/dev
9f51de5
@nul800sebastiaan
Merge branch 'v8/dev' into v8/contrib
2de635a
@nielslyngsoe
Merge remote-tracking branch 'origin/v8/contrib' into v8/temp_8695
d1eb20e
@nielslyngsoe
we need larger headlines to enable typographical hierarchy needed for…
c21736b 
… these dialogs with more content.
@nielslyngsoe
making the messages a little bit simpler
5b84be3
@nielslyngsoe
using callbacks over two way binded properties.
82de320
@nielslyngsoe
Copy link
Member

nielslyngsoe commented May 25, 2021 •
edited
Loading

@dawoe I see this Branch/PR is using the same code as #9125

Can I ask you to port over those changes? so they use the same approach? (or merge them, how you like.)

If any trouble let me know, I will be available.

Thanks in advance.

@dawoe
Copy link
Contributor Author

dawoe commented May 27, 2021

@nielslyngsoe changes haven been merged in to this one

@MushuPlatypus
Copy link

MushuPlatypus commented Feb 22, 2022

How is it going with PR? Has the functionality been added to the main branch yet?

@umbrabot
Copy link

umbrabot commented Feb 22, 2022

Hi there @dawoe!

Thanks for the contribution here and apologies if it has been a while since you heard from us. We have been in the very fortunate position of having lots of work to do. With this in mind, we are writing to let you know that with the release of the Long Term Support (LTS) version, 8.18, we have now moved into the support phase of Umbraco 8. You can read all about that here but to surmise, we will be keeping Umbraco 8 safe and well by releasing patching for security or regression issues if they arise but no longer will we do that for bug fixes. The same is still true for features, although we stopped merging those some time ago.

We'd love for you to keep contributing and while we are not able to merge this to Umbraco 8, if this is still something you'd like to see in Umbraco 9, please take a look and either create an issue to say so or find an issue that already exists. We'll be happy to give you some input around how you can adjust your pull request to target Umbraco 9. Even better, it might be something that Umbraco 9 already does or has. In which case, enjoy!

Once again, a huge thank you for the time you have spent working with us.

#H5YR
Your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot closed this Feb 22, 2022
@umbrabot umbrabot mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@poornimanayar poornimanayar poornimanayar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.