#10274 Variant sorting should take into account that there might not be any language (#10278)#10284
Merged
nul800sebastiaan merged 2 commits intov8/contribfrom May 19, 2021
Conversation
…be any language (#10278) * Variant sorting should take into account that there might not be any language available * fix languages Co-authored-by: Niels Lyngsø <nsl@umbraco.com> Co-authored-by: Mads Rasmussen <madsr@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When closing the Save & Publish dialog on variant content, we see an issue in the consol about
infiniteEditorsbeingundefined.This PR fixes general potential issues with infiniteEditors not being present.
I've tested my known case, but it seems there is an extensive amount of testing needed to verify that the original PR works as it should, so please find inspiration here.
The original PR is here: #8522
Fixes #10274