Element Picker: Adds valueSummary display and value resolver - #23154
Merged
Conversation
Adds a valueSummary extension so picked element names appear in collection view columns. Includes a value-type constant, batch resolver, variant-aware element, and a resolver unit test (11 cases).
leekelleher
added
category/ui
This comment was marked as resolved.
This comment was marked as resolved.
leekelleher
changed the title
valueSummary display and value resolver
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a value-summary extension for the Element Picker property editor so collection views can render selected element names (variant-aware) instead of raw IDs, and exposes a public value-type constant for downstream consumers.
Changes:
- Introduces
UMB_ELEMENT_PICKER_PROPERTY_EDITOR_VALUE_TYPEand augmentsUmbValueTypeMapwith the Element Picker’s value shape (Array<string>). - Adds a batch
valueResolverthat deduplicates uniques, fetches element items viaUmbElementItemRepository, and supports reactive updates viaasObservable. - Adds a
valueSummaryelement + manifests, wires them into the Element Picker manifests, and exports constants through the@umbraco-cms/backoffice/elementsbarrel.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-type/constants.ts | Adds exported value-type constant and UmbValueTypeMap typing for Element Picker values. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-summary/value-summary.ts | Barrel exports for the value summary element + resolver. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-summary/value-summary.resolver.ts | Batch resolver that fetches UmbElementItemModels for selected element uniques and provides reactive updates. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-summary/value-summary.resolver.test.ts | Unit tests for resolver behavior (empty, multi-pick, dedupe, unknown IDs, observable). |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-summary/value-summary.element.ts | Value summary UI element that renders resolved element names, variant-aware and comma-joined. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/value-summary/manifests.ts | Registers the value summary extension for the Element Picker value type. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/manifests.ts | Includes the new value summary manifests in the Element Picker extension set. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/element-picker/constants.ts | Re-exports Element Picker property-editor constants. |
| src/Umbraco.Web.UI.Client/src/packages/elements/property-editor/constants.ts | Re-exports property-editor constants from the elements package. |
| src/Umbraco.Web.UI.Client/src/packages/elements/constants.ts | Exposes property-editor constants via the top-level elements constants barrel. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
…mary - Call removeUmbControllerByAlias when removing a stale resolver so the named observer controller is released from the element's controller list - Call setData on existing resolvers when _value refreshes so renames are reflected without recreating the resolver - Remove redundant valueResolver re-export from resolver file (barrel handles it)
leekelleher
enabled auto-merge (squash)
June 17, 2026 14:55
AndyButland
approved these changes
Jun 18, 2026
AndyButland
left a comment
AndyButland
left a comment
Contributor
There was a problem hiding this comment.
Looks good and works as expected @leekelleher, and I've verified that it's aligned with the document picker.
Before:
After:
I see a few Sonarqube recommendations - none look critical, but worth a look over and apply if you agree with them.
I also saw @madsrasmussen had his 👀 on this one, so I'll approve with comments, but you may want to check with him before merging.
Member
|
All good. Code looks fine 👍 I have just updated with the latest from main. The failing e2e test does not seem to be related at all. |
- Mark #resolvers, #resolvedNames, and #repo as readonly - Replace .find() with .some() for existence checks - Flip negated condition in #syncResolvers to positive case first - Remove redundant type assertions in value-summary.resolver.ts
…ummary Extract #syncResolvers loop bodies into #removeResolver and #addOrUpdateResolver to eliminate nested branching flagged by CodeScene's Bumpy Road Ahead metric.
|
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up on PRs #22871/#23027, this PR adds a
valueSummaryfor the Element Picker (for Umbraco 18).Kudos to @engijlr for the original code, ref: de4683f. ✌️
Summary (AI/Claude generated) 🤖
valueSummaryextension for theUmbraco.ElementPickerproperty editor so picked element names are rendered in collection view columnsUMB_ELEMENT_PICKER_PROPERTY_EDITOR_VALUE_TYPEconstant (exported from@umbraco-cms/backoffice/elements) and wires it through the standardproperty-editor → element-pickerconstants chainUmbElementItemRepository, and returns positionally-alignedArray<UmbElementItemModel>withasObservablesupport; element renders all names variant-aware and comma-joinedTest plan
npm test -- --files "src/packages/elements/property-editor/element-picker/value-summary/value-summary.resolver.test.ts"— all 11 cases pass,Array<string>(not a JSON string) — if it arrives as a string, theTValueandUmbValueTypeMapentry will need updating