Property Editors: Add value summary extensions for collection views - #22871
Closed
engijlr wants to merge 41 commits into
Closed
Property Editors: Add value summary extensions for collection views#22871engijlr wants to merge 41 commits into
engijlr wants to merge 41 commits into
Conversation
added 8 commits
May 11, 2026 15:14
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…github.com/umbraco/Umbraco-CMS into v17/feature/value-summary-property-editors
madsrasmussen
self-requested a review
May 18, 2026 13:33
Member
|
@engijlr I haven't reviewed the code, but wondering whether we can have an Element Picker value-summary too? (since this PR is targeting main/v18.1). |
Contributor
…mary-property-editors
Replace the document icon with a check icon in value-summary components to indicate non-empty content. Updated the value-summary element in code-editor, markdown-editor, and tiptap-rte to return <uui-icon name='icon-check'> when a value is present, standardizing the visual cue across these editors.
madsrasmussen
approved these changes
Jun 1, 2026
Member
|
We encountered some technical challenges when merging this PR directly (some API errors from GitHub complaining about the base branch). We have squashed all the changes into this PR: #23027, merged it into v18.1, and cherry-picked it to v17.6. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
valueSummaryextensions across all remaining property editor types so collection table and card views display meaningful, compact representations instead of raw data or nothing.display resolved names. When multiple selections are allowed the text is truncated at
20chwith atitleattribute so the full value is visibleon hover
uui-tagbadge with the total count, keeping the cell compact regardless of how many items are selected20chwithtitleon hover20chBefore
After