Skip to content

Accessibility: Added missing labels to webhook details and headers #22918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 2 commits into from
May 22, 2026
Merged

Accessibility: Added missing labels to webhook details and headers #22918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00e82a4
Added missing labels to webhoot details and headers
andreaslborg May 20, 2026
ee69805
Changed toggle label to aria-label to remove visible text
andreaslborg May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/webhook/components/input-webhook-headers.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ export class UmbInputWebhookHeadersElement extends UmbLitElement {
override render() {
return html`
${this.#renderGrid()}
<uui-button id="add" look="placeholder" @click=${this.#addHeader}>Add</uui-button>
<uui-button id="add" look="placeholder" label=${this.localize.term('general_add')} @click=${this.#addHeader}>
<umb-localize key="general_add">Add</umb-localize>
</uui-button>
`;
}

Expand Down
4 changes: 2 additions & 2 deletions ...nt/src/packages/webhook/webhook/workspace/views/webhook-details-workspace-view.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export class UmbWebhookDetailsWorkspaceViewElement extends UmbLitElement impleme
mandatory
label=${this.localize.term('webhooks_url')}
description=${this.localize.term('webhooks_urlDescription')}>
<uui-input @input=${this.#onUrlChange} .value=${this._webhook.url} slot="editor" required="true"></uui-input>
<uui-input @input=${this.#onUrlChange} label=${this.localize.term('webhooks_url')} .value=${this._webhook.url} slot="editor" required="true"></uui-input>
</umb-property-layout>
<umb-property-layout
mandatory
Expand All @@ -122,7 +122,7 @@ export class UmbWebhookDetailsWorkspaceViewElement extends UmbLitElement impleme
<umb-property-layout
label=${this.localize.term('webhooks_enabled')}
description=${this.localize.term('webhooks_enabledDescription')}>
<uui-toggle slot="editor" .checked=${this._webhook.enabled} @change=${this.#onEnabledChange}></uui-toggle>
<uui-toggle slot="editor" aria-label=${this.localize.term('webhooks_enabled')} .checked=${this._webhook.enabled} @change=${this.#onEnabledChange}></uui-toggle>
</umb-property-layout>
<umb-property-layout
label=${this.localize.term('webhooks_headers')}
Expand Down
Loading