Skip to content

Accessibility: Added missing labels to webhook details and headers - #22918

Merged
AndyButland merged 2 commits into
umbraco:mainfrom
andreaslborg:v17/bugfix/webhook-missing-labels
May 22, 2026
Merged

Accessibility: Added missing labels to webhook details and headers#22918
AndyButland merged 2 commits into
umbraco:mainfrom
andreaslborg:v17/bugfix/webhook-missing-labels

Conversation

@andreaslborg

@andreaslborg andreaslborg commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Found missing label attributes on UUI controls in the webhook workspace causing accessibility console warnings.

UUI-INPUT needs a `label`
UUI-TOGGLE needs a `label`
UUI-BUTTON needs a `label`
image

Changes:

  • webhook-details-workspace-view.element.ts added webhooks_url label to uui-input, and the webhooks_enabled to uui-toggle, so accessible names are concise and match what the controls represent.

  • input-webhook-headers.element.ts added a localized label attribute to the "Add" uui-button (general_add) and replaced the hardcoded "Add" text with <umb-localize key="general_add">.

Testing

  1. Open the Webhooks section and create or edit a webhook.
  2. Open browser console: verify no needs a 'label' accessibility warnings appear for the URL input, the enabled toggle, or the Add headers button.
  3. Add a header and verify the "Add" button still functions correctly and displays the localized text.

@github-actions

Copy link
Copy Markdown

Hi there @andreaslborg, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@andreaslborg andreaslborg changed the title Accessibility: Added missing labels to webhoot details and headers Accessibility: Added missing labels to webhook details and headers May 20, 2026
@andreaslborg

Copy link
Copy Markdown
Contributor Author

Hi @AndyButland, should this also target v17/dev or is it fine as it?

@AndyButland

Copy link
Copy Markdown
Contributor

It's OK as is. We can cherry-pick it over. For future PRs though, I'd suggest targeting v17/dev if it's any sort of bug fix, accessibility improvement etc., as we'd want that in the LTS. main would be for 18+, so really only medium sized new features and of course anything that builds on an 18 only feature/

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreaslborg. Spotted one visual issue with this update - can you see what you think please?

@andreaslborg
andreaslborg requested a review from AndyButland May 22, 2026 15:41

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreaslborg - all looks good now.

@AndyButland
AndyButland merged commit 4344fe9 into umbraco:main May 22, 2026
32 checks passed
AndyButland pushed a commit that referenced this pull request May 22, 2026
…22918)

* Added missing labels to webhoot details and headers

* Changed toggle label to aria-label to remove visible text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants