Accessibility: Added missing labels to webhook details and headers - #22918
Conversation
|
Hi there @andreaslborg, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hi @AndyButland, should this also target v17/dev or is it fine as it? |
|
It's OK as is. We can cherry-pick it over. For future PRs though, I'd suggest targeting |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @andreaslborg. Spotted one visual issue with this update - can you see what you think please?
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @andreaslborg - all looks good now.
…22918) * Added missing labels to webhoot details and headers * Changed toggle label to aria-label to remove visible text
Description
Found missing
labelattributes on UUI controls in the webhook workspace causing accessibility console warnings.Changes:
webhook-details-workspace-view.element.tsaddedwebhooks_urllabel touui-input, and thewebhooks_enabledtouui-toggle, so accessible names are concise and match what the controls represent.input-webhook-headers.element.tsadded a localizedlabelattribute to the "Add"uui-button(general_add) and replaced the hardcoded "Add" text with<umb-localize key="general_add">.Testing
needs a 'label'accessibility warnings appear for the URL input, the enabled toggle, or the Add headers button.