Skip to content

Slider: fix duplicated property editor settings properties - #22898

Merged
nielslyngsoe merged 4 commits into
release/17.4.1from
v17/hotfix/slider-remove-duplicate-range-minimum-property
May 19, 2026
Merged

Slider: fix duplicated property editor settings properties#22898
nielslyngsoe merged 4 commits into
release/17.4.1from
v17/hotfix/slider-remove-duplicate-range-minimum-property

Merge branch 'release/17.4.1' into v17/hotfix/slider-remove-duplicate…

be30228
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (release/17.4.1) failed May 19, 2026 in 5m 50s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Bumpy Road Ahead)
Enforce critical code health rules (1 file with Bumpy Road Ahead)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
data-type-workspace.context.ts 1 rule in this hotspot 8.67 → 8.54 Suppress
Enforce critical code health rules Violations Code Health Impact
data-type-workspace.context.ts 1 critical rule 8.67 → 8.54 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead data-type-workspace.context.ts: UmbDataTypeWorkspaceContext.mergeConfigProperties 🔥

Annotations

Check warning on line 267 in src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/data-type-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/17.4.1)

❌ New issue: Bumpy Road Ahead

UmbDataTypeWorkspaceContext.mergeConfigProperties has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.