Slider: fix duplicated property editor settings properties

[nielslyngsoe]

Removes duplicate Property Editor settings and adds a client-side error when it happens.

[claude]

Claude finished @nielslyngsoe's task in 1m 59s —— View job

---

PR Review

Target: origin/release/17.4.1 · Based on commit: be30228e

Removes the duplicate minimumRange property setting from the Slider UI manifest (it was already defined in the schema manifest), adds a defensive duplicate-alias guard in the data type workspace context, and improves the minimumRange description.

• Other changes: Slider "Minimum range" PE setting description is now populated (was empty string); the duplicate check in #mergeConfigProperties() is a general guard that will fire for any property editor with duplicate aliases, not just slider.

---

Suggestions

• data-type-workspace.context.ts:263: throw new Error(...) is called inside an RxJS subscriber callback (via observe()). If source.subscribe(callback) propagates an uncaught synchronous throw, it may crash the workspace rather than showing a developer-friendly error. For this type of defensive/configuration guard, console.error() paired with a user-facing notification would be more resilient — the workspace could still render while surfacing the misconfiguration. Since the slider bug itself is fixed, this only matters if another property editor introduces the same mistake in future.

  // More resilient alternative:
  if (aliasSet.has(setting.alias)) {
      console.error(`Duplicate alias "${setting.alias}" in Property Editor configuration.`);
      // optionally: UmbNotificationContext notification
      continue; // or break, depending on preferred behaviour
  }

---

Approved with Suggestions for improvement

Good to go, but please carefully consider the importance of the suggestions.

[Copilot]

Pull request overview

Fixes duplicate minimumRange settings property on the Slider property editor (declared both in the schema manifest and the UI manifest) and adds a defensive client-side check in the data type workspace that throws when duplicate setting aliases are merged from schema/UI/data-source manifests.

Changes:

• Remove duplicated minimumRange property and its default value from the Slider UI manifest, keeping the canonical definition on the schema manifest (with the descriptive text moved to the schema).
• Add duplicate-alias detection in UmbDataTypeWorkspaceContext.#mergeConfigProperties that throws when two merged settings share an alias.
• Minor refactor in #transferConfigDefaultData: rename the loop variable from defaultDataItem to property and remove an outdated TODO comment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/Umbraco.Slider.ts	Adds a meaningful description to the schema's minimumRange property.
src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/manifests.ts	Removes the duplicate minimumRange property and default-data entry from the UI manifest.
src/Umbraco.Web.UI.Client/src/packages/data-type/workspace/data-type-workspace.context.ts	Adds duplicate-alias detection on merged settings and renames a loop variable for clarity.