Skip to content

Accessibility: Added missing labels to number fields in the settings tab #22667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 1 commit into from
May 1, 2026
Merged

Accessibility: Added missing labels to number fields in the settings tab #22667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...s/workspace/document-type/views/settings/document-type-workspace-view-settings.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,21 +177,23 @@
type="number"
id="versions-newer-than-days"
min="0"
label=${this.localize.term('contentTypeEditor_historyCleanupKeepAllVersionsNewerThanDays')}
placeholder="7"
.value=${this._keepAllVersionsNewerThanDays?.toString() ?? ''}
@change=${this.#onChangeKeepAllVersionsNewerThanDays}></uui-input>
</uui-form-layout-item>

<uui-form-layout-item>
<uui-label slot="label" for="latest-version-per-day-days">
<umb-localize key="contentTypeEditor_historyCleanupKeepLatestVersionPerDayForDays"
>Keep latest version per day for days</umb-localize
>
</uui-label>
<uui-input
type="number"
id="latest-version-per-day-days"
min="0"
label=${this.localize.term('contentTypeEditor_historyCleanupKeepLatestVersionPerDayForDays')}

Check warning on line 196 in src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/document-type/views/settings/document-type-workspace-view-settings.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

❌ Getting worse: Large Method 

UmbDocumentTypeWorkspaceViewSettingsElement.render increases from 92 to 94 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
placeholder="90"
.value=${this._keepLatestVersionPerDayForDays?.toString() ?? ''}
@change=${this.#onChangeKeepLatestVersionPerDayForDays}></uui-input>
Expand Down
Loading