Skip to content

Accessibility: Added missing labels to number fields in the settings tab#22667

Merged
nielslyngsoe merged 1 commit into
umbraco:mainfrom
andreaslborg:v17/bugfix/missing-number-labels
May 1, 2026
Merged

Accessibility: Added missing labels to number fields in the settings tab#22667
nielslyngsoe merged 1 commit into
umbraco:mainfrom
andreaslborg:v17/bugfix/missing-number-labels

Conversation

@andreaslborg

Copy link
Copy Markdown
Contributor

Description

The two number input fields shown in the settings tab were both missing labels.

image

This caused the console warning UUI-INPUT needs a label to appear.

Added the same localized term used in the labels to the input fields.

image

@github-actions

Copy link
Copy Markdown

Hi there @andreaslborg, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nielslyngsoe nielslyngsoe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants