Deprecations: Client-side removal of v18 deprecated code - #21984
CodeScene PR Check
Quality Gate Failed
(5 files improve in Code Health)
Gates Failed
(1 file with Overall Code Complexity)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| content-detail-workspace-base.ts | 1 advisory rule | 6.90 → 6.50 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| tree-repository-base.ts | 9.69 → 10.00 | Complex Method |
| tree-item-children.manager.ts | 8.45 → 8.63 | Complex Method, Bumpy Road Ahead |
| tree-data.request-manager.ts | 8.82 → 9.39 | Overall Code Complexity |
| property.element.ts | 8.71 → 8.73 | Complex Method |
| property-editor-ui-textarea.element.ts | 9.69 → 10.00 | Complex Method |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity content-detail-workspace-base.ts
✅ Improving Code Health:
- Complex Method property.element.ts: UmbPropertyElement._gotEditorUI
- Complex Method tree-item-children.manager.ts: UmbTreeItemChildrenManager.loadPrevItemsFromTarget
- Complex Method tree-repository-base.ts: UmbTreeRepositoryBase.requestTreeItemsOf
- Bumpy Road Ahead tree-item-children.manager.ts: UmbTreeItemChildrenManager.loadPrevItemsFromTarget
- Overall Code Complexity tree-data.request-manager.ts
- Complex Method property-editor-ui-textarea.element.ts: UmbPropertyEditorUITextareaElement.setconfig
Annotations
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ No longer an issue: Complex Method
UmbTreeRepositoryBase.requestTreeItemsOf is no longer above the threshold for cyclomatic complexity
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ Getting better: Complex Method
UmbTreeItemChildrenManager.loadPrevItemsFromTarget decreases in cyclomatic complexity from 15 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ No longer an issue: Bumpy Road Ahead
UmbTreeItemChildrenManager.loadPrevItemsFromTarget is no longer above the threshold for logical blocks with deeply nested code
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ No longer an issue: Overall Code Complexity
The mean cyclomatic complexity in this module is no longer above the threshold
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 4.03 across 40 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ Getting better: Complex Method
UmbPropertyElement._gotEditorUI decreases in cyclomatic complexity from 21 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ No longer an issue: Complex Method
UmbPropertyEditorUITextareaElement.setconfig is no longer above the threshold for cyclomatic complexity