Skip to content

Deprecations: Client-side removal of v18 deprecated code#21984

Merged
iOvergaard merged 11 commits into
v18/devfrom
v18/task/remove-client-deprecations
Apr 9, 2026
Merged

Deprecations: Client-side removal of v18 deprecated code#21984
iOvergaard merged 11 commits into
v18/devfrom
v18/task/remove-client-deprecations

Conversation

@leekelleher

@leekelleher leekelleher commented Mar 3, 2026

Copy link
Copy Markdown
Member

Description

Removed all deprecated client-side code scheduled for removal in v18.

Breaking changes

treeStore extension type removed

The treeStore extension type and all related APIs have been removed:

  • ManifestTreeStore interface and treeStore extension type registration
  • All built-in tree store implementations (e.g. UmbDocumentTreeStore, UmbMediaTreeStore)
  • Tree store context tokens
  • The UmbExtensionsApiInitializer for treeStore in the core entry point

Custom packages registering treeStore extensions will have them silently ignored. Tree data is now managed directly by tree repositories.

Other removed deprecations
  • skip/take properties on tree request args — use paging object instead
  • UmbElementValueModel.entityType property
  • _items getter/setter on UmbTrashEntityBulkAction
  • _items accessor on UmbDeleteEntityBulkAction
  • parent observable on menu structure workspace contexts — use UMB_PARENT_ENTITY_CONTEXT instead
  • getContentTypeId() on workspace contexts — use getContentTypeUnique() instead
  • getManifest() and loadMore() on tree item contexts
  • property-value-change event (use UmbPropertyValueChangeEvent via umb-property-value-change)
  • UmbSectionDefaultElement re-export alias
  • Deprecated camelCase UFM filter aliases
  • PackageManifestResponse type alias
  • MediaValueType type alias
  • ActiveVariant type alias
  • UrlParametersRecord type alias
  • Deprecated collection manifest getter/setter methods

leekelleher and others added 6 commits February 12, 2026 14:03
Remove the entire tree store pattern that was deprecated in favor of
direct tree repository queries. This deletes 29 tree store files,
removes the ManifestTreeStore extension type, updates all 15+ tree
repository constructors to remove store context token parameters,
cleans up manifests/constants/index exports, and migrates all
skip/take pagination to the paging property pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove deprecated methods/properties across workspace contexts, menu
structures, tree items, and collections:
- Tree item context: getManifest(), loadMore()
- Content workspace: loadSegments()
- Entity detail workspace: parentUnique/parentEntityType observables,
  getParent/setParent/getParentUnique/getParentEntityType methods,
  _scaffoldProcessData (replaced by _processIncomingData)
- Menu structure contexts: #parent state, provideContext('UmbMenuStructureWorkspaceContext')
- Document/media/blueprint/member workspaces: contentTypeHasCollection,
  getCollectionAlias(), getContentTypeId() (replaced by getContentTypeUnique())
- Collection context: setManifest(), getManifest() from interface and implementation
- Bulk delete action: deprecated _items getter/setter

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove deprecated type aliases scheduled for v18 removal:
- PackageManifestResponse (use UmbPackageManifestResponse)
- UmbSectionDefaultElement (use UmbDefaultSectionElement)
- ConditionsCollectionView (use UmbConditionsCollectionView)
- MediaValueType (use UmbMediaValueType)
- UrlParametersRecord (use UmbUrlParametersRecord)
- ActiveVariant (use UmbActiveVariant)
- UmbPropertyValueChangeEvent class and deprecated property-value-change
  event listeners

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Textarea: remove deprecated minHeight/maxHeight config reads
- Image cropper modal: remove deprecated default export
- UFM filters: remove 3 deprecated camelCase filter manifests
  (StripHtmlCamelCase, TitleCaseCamelCase, WordLimitCamelCase)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…PagedModel

Make totalAfter and totalBefore required properties (were optional),
fulfilling the TODO to make these mandatory in v18. All downstream
tree data sources already provide these values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Auto-fixed formatting from lint run (line wrapping, trailing newlines).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@leekelleher leekelleher marked this pull request as ready for review March 30, 2026 10:02
Copilot AI review requested due to automatic review settings March 30, 2026 10:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes client-side deprecated APIs slated for removal in v18, primarily around tree stores/aliases, legacy pagination (skip/take), and various deprecated workspace/property-editor APIs.

Changes:

  • Removes deprecated treeStore classes/context-tokens/manifests and updates tree repositories to rely on repositories + paging.
  • Removes deprecated methods/types/aliases across packages (e.g. getContentTypeId, legacy event types, deprecated exports).
  • Updates tree/server data flows to use paging and (now required) totalBefore/totalAfter.

Reviewed changes

Copilot reviewed 148 out of 149 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
src/Umbraco.Web.UI.Client/src/packages/ufm/filters/manifests.ts Removes deprecated camelCase UFM filter aliases.
src/Umbraco.Web.UI.Client/src/packages/templating/templates/tree/template-tree.store.ts Deletes deprecated template tree store.
src/Umbraco.Web.UI.Client/src/packages/templating/templates/tree/template-tree.store.context-token.ts Deletes deprecated template tree store context token.
src/Umbraco.Web.UI.Client/src/packages/templating/templates/tree/template-tree.repository.ts Removes tree store dependency; updates root request to use paging.
src/Umbraco.Web.UI.Client/src/packages/templating/templates/tree/manifests.ts Removes treeStore manifest/alias; keeps repository/tree manifests.
src/Umbraco.Web.UI.Client/src/packages/templating/templates/tree/index.ts Stops exporting removed store APIs.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/stylesheet-tree.store.ts Deletes deprecated stylesheet tree store.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/stylesheet-tree.store.context-token.ts Deletes deprecated stylesheet tree store context token.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/stylesheet-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter to responses.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/stylesheet-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/manifests.ts Removes treeStore manifest/alias.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/index.ts Stops exporting removed store type.
src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/tree/constants.ts Removes store exports; keeps repository/tree constants.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/script-tree.store.ts Deletes deprecated script tree store.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/script-tree.store.context-token.ts Deletes deprecated script tree store context token.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/script-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/script-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/manifests.ts Removes treeStore manifest/alias.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/index.ts Stops exporting removed store APIs.
src/Umbraco.Web.UI.Client/src/packages/templating/scripts/tree/constants.ts Removes store exports; keeps repository/tree constants.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/partial-view-tree.store.ts Deletes deprecated partial view tree store.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/partial-view-tree.store.context-token.ts Deletes deprecated partial view tree store context token.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/partial-view-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/partial-view-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/manifests.ts Removes treeStore manifest/alias.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/index.ts Stops exporting removed store type.
src/Umbraco.Web.UI.Client/src/packages/templating/partial-views/tree/constants.ts Removes store exports; keeps repository/tree constants.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/static-file-tree.store.ts Deletes deprecated static-file tree store.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/static-file-tree.store.context-token.ts Deletes deprecated static-file tree store context token.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/static-file-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/static-file-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/static-file/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/property-editors/textarea/property-editor-ui-textarea.element.ts Removes deprecated min/max height config support; sets defaults.
src/Umbraco.Web.UI.Client/src/packages/packages/types.ts Removes deprecated PackageManifestResponse alias.
src/Umbraco.Web.UI.Client/src/packages/members/member/workspace/member/member-workspace.context.ts Removes deprecated getContentTypeId.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/tree-item-children/collection/repository/member-type-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/member-type-tree.store.ts Deletes deprecated member-type tree store.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/member-type-tree.store.context-token.ts Deletes deprecated member-type tree store context token.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/member-type-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/views/info/media-workspace-view-info.element.ts Switches from deprecated getContentTypeId to getContentTypeUnique.
src/Umbraco.Web.UI.Client/src/packages/media/media/workspace/media-workspace.context.ts Removes deprecated collection/type helpers.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/media-tree.store.ts Deletes deprecated media tree store.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/media-tree.store.context-token.ts Deletes deprecated media tree store context token.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/media-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/index.ts Stops exporting removed store type.
src/Umbraco.Web.UI.Client/src/packages/media/media/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/tree-item-children/collection/repository/media-recycle-bin-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/media-recycle-bin-tree.store.ts Deletes deprecated recycle-bin media tree store.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/media-recycle-bin-tree.store.context-token.ts Deletes deprecated recycle-bin media tree store context token.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/media-recycle-bin-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/media-recycle-bin-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/index.ts Stops exporting removed store type.
src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/media/media/property-editors/upload-field/types.ts Removes deprecated MediaValueType alias interface.
src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/media-picker-modal.element.ts Updates tree request args to use paging.
src/Umbraco.Web.UI.Client/src/packages/media/media/modals/image-cropper-editor/image-cropper-editor-modal.element.ts Removes deprecated default export.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/tree-item-children/collection/repository/media-type-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/media-type-tree.store.ts Deletes deprecated media-type tree store.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/media-type-tree.store.context-token.ts Deletes deprecated media-type tree store context token.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/media-type-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/management-api/tree/tree-data.request-manager.ts Removes backwards-compat args.skip/take fallback.
src/Umbraco.Web.UI.Client/src/packages/language/menu/language-menu-structure.context.ts Removes obsolete context alias provisioning.
src/Umbraco.Web.UI.Client/src/packages/elements/tree/element-tree.repository.ts Updates root request args to use paging.
src/Umbraco.Web.UI.Client/src/packages/elements/recycle-bin/tree/element-recycle-bin-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/elements/recycle-bin/tree/element-recycle-bin-tree.repository.ts Updates root request args to use paging.
src/Umbraco.Web.UI.Client/src/packages/elements/recycle-bin/collection/repository/element-recycle-bin-tree-item-children-collection.repository.ts Updates collection paging arg shape.
src/Umbraco.Web.UI.Client/src/packages/elements/publishing/publish/entity-action/publish.action.ts Minor formatting-only change.
src/Umbraco.Web.UI.Client/src/packages/elements/collection/repository/element-collection.repository.ts Updates collection paging arg shape.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts Switches from deprecated getContentTypeId to getContentTypeUnique.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts Removes deprecated collection/type helpers.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/tree/manifests.ts Removes treeStore manifest/alias.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/tree/index.ts Stops exporting removed store APIs.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/tree/document-tree.store.ts Deletes deprecated document tree store.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/tree/document-tree.store.context-token.ts Deletes deprecated document tree store context token.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/tree/document-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/tree-item-children/collection/repository/document-recycle-bin-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/manifests.ts Removes recycle-bin treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/index.ts Stops exporting removed store type.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/document-recycle-bin-tree.store.ts Deletes deprecated recycle-bin tree store.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/document-recycle-bin-tree.store.context-token.ts Deletes deprecated recycle-bin tree store context token.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/document-recycle-bin-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/data/document-recycle-bin-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/tree-item-children/collection/repository/document-type-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/document-type.tree.store.ts Deletes deprecated document-type tree store.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/document-type.tree.store.context-token.ts Deletes deprecated document-type tree store context token.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/document-type-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/documents/document-types/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/workspace/document-blueprint-workspace.context.ts Removes deprecated collection/type helpers.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.store.ts Deletes deprecated document-blueprint tree store.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.store.context-token.ts Deletes deprecated document-blueprint tree store context token.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/document-blueprint-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/documents/document-blueprints/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/index.ts Stops exporting removed store APIs.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/dictionary-tree.store.ts Deletes deprecated dictionary tree store.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/dictionary-tree.server.data-source.ts Switches to paging and adds totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/dictionary-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/dictionary/tree/constants.ts Removes store constants.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/tree-item-children/collection/repository/data-type-tree-item-children-collection.repository.ts Reworks collection repo to use tree repository + paging.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/manifests.ts Removes treeStore manifest.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/data-type-tree.store.ts Deletes deprecated data-type tree store.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/data-type-tree.store.context-token.ts Deletes deprecated data-type tree store context token.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/data-type-tree.repository.ts Removes tree store dependency; uses paging.
src/Umbraco.Web.UI.Client/src/packages/data-type/tree/constants.ts Removes store constants/exports.
src/Umbraco.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts Removes deprecated parent APIs and _scaffoldProcessData.
src/Umbraco.Web.UI.Client/src/packages/core/workspace/controllers/workspace-split-view-manager.controller.ts Removes deprecated ActiveVariant type alias.
src/Umbraco.Web.UI.Client/src/packages/core/utils/path/url-pattern-to-string.function.ts Removes deprecated UrlParametersRecord type alias.
src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts Removes skip/take backwards-compat request args; removes runtime totalBefore check.
src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-base/tree-item-context-base.ts Removes deprecated getManifest() and loadMore().
src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item-children/tree-item-children-collection-repository-base.ts Updates paging args shape for collection-backed tree children.
src/Umbraco.Web.UI.Client/src/packages/core/tree/entity-actions/sort-children-of/modal/sort-children-of-modal.element.ts Updates paging args shape.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/unique-tree-store.ts Deletes deprecated unique tree store implementation.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/types.ts Removes deprecated skip/take fields from request args types.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/tree-store.interface.ts Deletes deprecated tree store interface.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/tree-repository.interface.ts Removes deprecated observable-based methods.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/tree-repository-base.ts Removes tree-store integration; repository no longer manages store-backed observables.
src/Umbraco.Web.UI.Client/src/packages/core/tree/data/index.ts Stops exporting tree store types/impl.
src/Umbraco.Web.UI.Client/src/packages/core/section/default/default-section.element.ts Removes deprecated re-export alias.
src/Umbraco.Web.UI.Client/src/packages/core/repository/types.ts Makes UmbTargetPagedModel.totalBefore/totalAfter mandatory.
src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts Removes deprecated property-value-change listener support.
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/index.ts Stops exporting removed event API surface.
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/events/property-value-change.event.ts Deletes deprecated event type.
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/events/index.ts Removes export barrel for deleted event.
src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-variant-tree-structure-workspace-context-base.ts Removes deprecated parent observable and obsolete context alias.
src/Umbraco.Web.UI.Client/src/packages/core/menu/menu-tree-structure-workspace-context-base.ts Removes deprecated parent observable and obsolete context alias.
src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/extensions/store.extension.ts Removes deprecated treeStore extension manifest type.
src/Umbraco.Web.UI.Client/src/packages/core/entry-point.ts Removes treeStore initializer.
src/Umbraco.Web.UI.Client/src/packages/core/entity-bulk-action/common/bulk-delete/bulk-delete.action.ts Removes deprecated _items accessor.
src/Umbraco.Web.UI.Client/src/packages/core/collection/view/collection-view.extension.ts Removes deprecated interface alias.
src/Umbraco.Web.UI.Client/src/packages/core/collection/types.ts Removes deprecated manifest setter/getter from collection context type.
src/Umbraco.Web.UI.Client/src/packages/core/collection/default/collection-default.context.ts Removes deprecated manifest accessor methods.
src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts Removes deprecated loadSegments wrapper.
src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-property.element.ts Formatting-only template change.
src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/content-type-workspace-context-base.ts Switches scaffold processing to _processIncomingData.
src/Umbraco.Web.UI.Client/src/packages/block/block/events/index.ts Formatting-only change.
src/Umbraco.Web.UI.Client/src/packages/block/block-rte/components/block-rte-entry/block-rte-entry.element.ts Formatting-only change.
src/Umbraco.Web.UI.Client/examples/tree/tree/data/local-data-source/tree.local.data-source.ts Updates example tree responses to include totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/examples/picker-data-source/example-custom-picker-tree-data-source.ts Updates example picker data source responses to include totalBefore/totalAfter.
src/Umbraco.Web.UI.Client/.storybook/preview.js Removes treeStore initializer in Storybook preview host.

leekelleher and others added 2 commits March 30, 2026 11:44
…itories

The UmbCollectionRepository interface defines filter as optional.
Without a default, calling requestCollection() without arguments
would throw when accessing filter.skip/filter.take.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 142 out of 143 changed files in this pull request and generated 17 comments.

@iOvergaard iOvergaard added preview/storybook Pull requests that can be previewed through Storybook preview/backoffice Pull requests that can be previewed in a static version of the Backoffice labels Apr 7, 2026
@nielslyngsoe nielslyngsoe requested a review from iOvergaard April 8, 2026 06:59
iOvergaard and others added 2 commits April 9, 2026 12:43
Resolve conflict in menu-tree-structure-workspace-context-base.ts:
- Keep _sectionContext (used by new v18/dev code)
- Remove deprecated #parent observable (scheduled for v18 removal)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…remove missed deprecations

- Remove unused UmbObjectState import (ESLint error from merge)
- Remove unused offsetPaging variable in tree-item-children.manager.ts
- Fix totalBefore/totalAfter in all tree data sources to account for skip
  offset (was always reporting totalBefore: 0 regardless of skip value)
- Remove deprecated entityType property from UmbElementValueModel
  (marked for v18 removal)
- Remove deprecated _items getter/setter from UmbTrashEntityBulkAction
  (marked for v18 removal)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-21984.westeurope.6.azurestaticapps.net

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-21984.westeurope.6.azurestaticapps.net

…fter type removal

Remove entityType property from test fixtures and media-dropzone.manager.ts
following removal of the deprecated entityType from UmbElementValueModel.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-21984.westeurope.6.azurestaticapps.net

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-sea-0c7411a03-21984.westeurope.6.azurestaticapps.net

@iOvergaard iOvergaard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged v18/dev and resolved conflicts. Made the following additional changes on top of Lee's work:

ESLint fixes (blocking CI):

  • Removed unused UmbObjectState import (leftover from merge conflict)
  • Removed unused offsetPaging variable in tree-item-children.manager.ts

Pagination metadata fix (from Copilot review):

  • Fixed totalBefore/totalAfter in all 10 tree data source locations to correctly account for skip offset — was always reporting totalBefore: 0 regardless of skip value

Missed v18 deprecation removals:

  • Removed deprecated entityType property from UmbElementValueModel (and all test/source references)
  • Removed deprecated _items getter/setter from UmbTrashEntityBulkAction

Not changed (intentionally):

  • UmbContentTypeModel (deprecated since v17, 81 usages across 32 files) — needs its own dedicated PR
  • Copilot comments about filter defaults and target pagination in file-system data sources — addressed in review comments on the PR

@iOvergaard iOvergaard enabled auto-merge (squash) April 9, 2026 13:21
@iOvergaard iOvergaard merged commit 8df1c3f into v18/dev Apr 9, 2026
28 of 29 checks passed
@iOvergaard iOvergaard deleted the v18/task/remove-client-deprecations branch April 9, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend category/breaking preview/backoffice Pull requests that can be previewed in a static version of the Backoffice preview/storybook Pull requests that can be previewed through Storybook release/18.0.0 type/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants