Skip to content

Block Workspace: rename root-tab to 'generic' #21699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 2 commits into from
Feb 10, 2026
Merged

Block Workspace: rename root-tab to 'generic' #21699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86f8821
renme to generic
nielslyngsoe Feb 10, 2026
b9caf27
only use label
nielslyngsoe Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...s/block/block/workspace/views/edit/block-workspace-view-edit-content-no-router.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ export class UmbBlockWorkspaceViewEditContentNoRouterElement extends UmbLitEleme
? html`<uui-tab
label=${this.localize.term('general_generic')}
.active=${this._activeTabKey === null}
@click=${() => this.#setTabKey(null)}
>Content</uui-tab
>`
@click=${() => this.#setTabKey(null)}></uui-tab>`
: nothing}
${repeat(
this._tabs,
Expand Down
9 changes: 4 additions & 5 deletions ...Client/src/packages/block/block/workspace/views/edit/block-workspace-view-edit.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,16 +147,15 @@ export class UmbBlockWorkspaceViewEditElement extends UmbLitElement implements U
if (!this._routes || !this._tabs) return;
return html`
<umb-body-layout header-fit-height>
${this._routerPath && (this._tabs.length > 1 || (this._tabs.length === 1 && (this._hasRootGroups || this._hasRootProperties)))
${this._routerPath &&
(this._tabs.length > 1 || (this._tabs.length === 1 && (this._hasRootGroups || this._hasRootProperties)))
? html` <uui-tab-group slot="header">
${(this._hasRootGroups || this._hasRootProperties) && this._tabs.length > 0
? html`
<uui-tab
label="Content"
label=${this.localize.term('general_generic')}
.active=${this._routerPath + '/' === this._activePath}
href=${this._routerPath + '/'}>
<umb-localize key="general_content">Content</umb-localize>
</uui-tab>
href=${this._routerPath + '/'}></uui-tab>
`
: ''}
${repeat(
Expand Down
Loading