Block Editors: avoid discard changes for no changes (Fixes #20680) - #20941
Merged
nielslyngsoe merged 3 commits intoNov 24, 2025
CodeScene Delta Analysis / CodeScene Code Health Review (release/16.4)
failed
Nov 24, 2025 in 57s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Bumpy Road Ahead)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| property-editor-ui-block-grid.element.ts | 1 critical rule | 8.64 → 8.47 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| property-editor-ui-block-grid.element.ts | 1 advisory rule | 8.64 → 8.47 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method property-editor-ui-block-grid.element.ts: UmbPropertyEditorUIBlockGridElement.constructor
- Bumpy Road Ahead property-editor-ui-block-grid.element.ts: UmbPropertyEditorUIBlockGridElement.constructor
Annotations
codescene-delta-analysis / CodeScene Code Health Review (release/16.4)
❌ Getting worse: Complex Method
UmbPropertyEditorUIBlockGridElement.constructor increases in cyclomatic complexity from 20 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (release/16.4)
❌ New issue: Bumpy Road Ahead
UmbPropertyEditorUIBlockGridElement.constructor has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading