Block Editors: avoid discard changes for no changes (Fixes #20680)#20941
Merged
nielslyngsoe merged 3 commits intorelease/16.4from Nov 24, 2025
Merged
Block Editors: avoid discard changes for no changes (Fixes #20680)#20941nielslyngsoe merged 3 commits intorelease/16.4from
nielslyngsoe merged 3 commits intorelease/16.4from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #20680 where block editors (Block List, Block Grid, and RTE with blocks) were prompting users to discard changes even when no actual changes were made. The root cause was that observable value updates were being triggered unnecessarily, causing the change detection system to incorrectly identify unsaved changes.
Key Changes:
- Imported and used
jsonStringComparisonutility to compare values before updating them - Added early return checks when values are identical to prevent spurious change detection
- Applied the fix consistently across three block editor components
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts |
Added value comparison checks in three locations within the observable callback to prevent unnecessary updates when layouts/content/settings haven't changed |
src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts |
Added value comparison checks in two locations to prevent setting undefined when already undefined and to avoid updates when the new value matches the current value |
src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts |
Added value comparison checks in two locations, mirroring the block-list implementation for consistency |
iOvergaard
approved these changes
Nov 24, 2025
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20680
Fixes cherry-picked from v.17