Skip to content

Trees: Restore backward compatibility for file system based tree controllers (closes #20602) - #20608

Merged
AndyButland merged 3 commits into
mainfrom
v16/bugfix/resolve-backward-compatibility-for-file-system-controllers
Oct 22, 2025
Merged

Trees: Restore backward compatibility for file system based tree controllers (closes #20602)#20608
AndyButland merged 3 commits into
mainfrom
v16/bugfix/resolve-backward-compatibility-for-file-system-controllers

Aligned obsoletion messages.

3ad3f83
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Oct 22, 2025 in 32s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Excess Number of Function Arguments)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
FileSystemTreeControllerBase.cs 1 advisory rule 9.39 → 9.10 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments FileSystemTreeControllerBase.cs: GetPathViewModels

✅ Improving Code Health:

  • String Heavy Function Arguments FileSystemTreeControllerBase.cs

Annotations

Check warning on line 144 in src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Excess Number of Function Arguments

GetPathViewModels has 6 arguments, max arguments = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check notice on line 1 in src/Umbraco.Cms.Api.Management/Controllers/Tree/FileSystemTreeControllerBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ Getting better: String Heavy Function Arguments

The ratio of strings in function arguments decreases from 43.48% to 41.38%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.