Skip to content

Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336 for 13) - #20344

Merged
AndyButland merged 4 commits into
v13/devfrom
v13/bugfix/fix-handling-of-null-representation-in-cache
Oct 2, 2025
Merged

Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336 for 13)#20344
AndyButland merged 4 commits into
v13/devfrom
v13/bugfix/fix-handling-of-null-representation-in-cache

Amend tests so they verify that cached null values are also removed

b367604
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Umbraco CMS 9+ succeeded Oct 2, 2025 in 27m 17s

Build #13.12.0--rc.preview.9+0b5cae1 had test failures

Details

Tests

  • Failed: 1 (0.01%)
  • Passed: 14,141 (99.30%)
  • Other: 99 (0.70%)
  • Total: 14,241

Annotations

Check failure on line 198 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Build log #L198

PowerShell exited with code '1'.

Check failure on line 1 in Help panel links › Check the youtube link works as expected

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Help panel links › Check the youtube link works as expected

helpLinks.spec.ts:17:5 Check the youtube link works as expected
Raw output
  [chromium] › DefaultConfig\HelpPanel\helpLinks.spec.ts:17:5 › Help panel links › Check the youtube link works as expected 

    Test timeout of 40000ms exceeded.

    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('[aria-label="Reject all"]').first() to be visible
    ============================================================

      28 |       // If the YouTube consent popup is displayed, interact with it
      29 |       const rejectAllButton = await youtubePopup.locator('[aria-label="Reject all"]').first();
    > 30 |       await rejectAllButton.waitFor({ state: "visible" });
         |                             ^
      31 |       await rejectAllButton.click();
      32 |
      33 |       // Assert the URL of the popup

        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\HelpPanel\helpLinks.spec.ts:30:29

    Pending operations:
      - locator.waitFor at tests\DefaultConfig\HelpPanel\helpLinks.spec.ts:30:29


    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-HelpPanel-helpLinks-Help-panel-links-Check-the-youtube-link-works-as-expected-chromium\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-HelpPanel-helpLinks-Help-panel-links-Check-the-youtube-link-works-as-expected-chromium\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────

    Test timeout of 40000ms exceeded.

    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('[aria-label="Reject all"]').first() to be visible
    ============================================================

      28 |       // If the YouTube consent popup is displayed, interact with it
      29 |       const rejectAllButton = await youtubePopup.locator('[aria-label="Reject all"]').first();
    > 30 |       await rejectAllButton.waitFor({ state: "visible" });
         |                             ^
      31 |       await rejectAllButton.click();
      32 |
      33 |       // Assert the URL of the popup

        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\HelpPanel\helpLinks.spec.ts:30:29

    Pending operations:
      - locator.waitFor at tests\DefaultConfig\HelpPanel\helpLinks.spec.ts:30:29


    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-HelpPanel-helpLinks-Help-panel-links-Check-the-youtube-link-works-as-expected-chromium-retry1\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-HelpPanel-helpLinks-Help-panel-links-Check-the-youtube-link-works-as-expected-chromium-retry1\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────

    Test timeout of 40000ms exceeded.

    Error: locator.waitFor: Page closed
    =========================== logs ===========================
    waiting for locator('[aria-label="Reject all"]').first() to be visible
    ============================================================

      28 |       // If the YouTube consent popup is displayed, interact with it
      29 |       const rejectAllButton = await youtubePopup.locator('[aria-label="Reject all"]').first();
    > 30 |       await rejectAllButton.waitFor({ state: "visible" });
         |                             ^
      31 |       await rejectAllButton.click();
      32 |
      33 |       // Assert the URL of the popup

        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\HelpPanel\helpLinks.spec.ts:30:29

    Pending operations:
      - locator.waitFor at tests\D