Caching: Fixes regression of the caching of null representations for missing dictionary items (closes #20336 for 13) - #20344
Merged
AndyButland merged 4 commits intoOct 2, 2025
CodeScene Delta Analysis / CodeScene Code Health Review (v13/dev)
failed
Oct 2, 2025 in 32s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| AppCacheExtensions.cs | 1 advisory rule | 9.39 → 8.82 | Suppress |
| DictionaryRepositoryTest.cs | 1 advisory rule | 7.55 → 7.11 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication DictionaryRepositoryTest.cs
- Code Duplication AppCacheExtensions.cs
Annotations
Check warning on line 57 in src/Umbraco.Core/Cache/AppCacheExtensions.cs
codescene-delta-analysis / CodeScene Code Health Review (v13/dev)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: GetCacheItem,GetCacheItem. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
codescene-delta-analysis / CodeScene Code Health Review (v13/dev)
❌ Getting worse: Code Duplication
introduced similar code in: Can_Perform_Cached_Request_For_Existing_Value_By_Key_On_DictionaryRepository_With_Cache,Can_Perform_Cached_Request_For_NonExisting_Value_By_Key_On_DictionaryRepository_With_Cache,Cannot_Perform_Cached_Request_For_Existing_Value_By_Key_On_DictionaryRepository_Without_Cache,Cannot_Perform_Cached_Request_For_NonExisting_Value_By_Key_On_DictionaryRepository_Without_Cache. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading