Skip to content

Tiptap: Relocation of external extensions/package - #20256

Merged
iOvergaard merged 16 commits into
v17/devfrom
v17/feature/tiptap-externals-relocation
Sep 25, 2025
Merged

Tiptap: Relocation of external extensions/package#20256
iOvergaard merged 16 commits into
v17/devfrom
v17/feature/tiptap-externals-relocation

Naming of Tiptap extension option interfaces

1bab919
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v17/dev) failed Sep 24, 2025 in 46s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Code Duplication, Complex Method, Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
table.tiptap-extension.ts 3 advisory rules 10.00 → 8.55 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication table.tiptap-extension.ts
  • Complex Conditional table.tiptap-extension.ts: isColumnGripSelected
  • Complex Conditional table.tiptap-extension.ts: isRowGripSelected
  • Complex Method table.tiptap-extension.ts: isRowGripSelected
  • Complex Method table.tiptap-extension.ts: isColumnGripSelected

Annotations

Check warning on line 527 in src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)

❌ New issue: Code Duplication

The module contains 4 functions with similar structure: UmbTableCell.addProseMirrorPlugins,UmbTableHeader.addProseMirrorPlugins,isColumnGripSelected,isRowGripSelected. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 527 in src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)

❌ New issue: Complex Method

isRowGripSelected has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 497 in src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)

❌ New issue: Complex Method

isColumnGripSelected has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 484 in src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)

❌ New issue: Complex Conditional

isColumnGripSelected has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 514 in src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/table/table.tiptap-extension.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)

❌ New issue: Complex Conditional

isRowGripSelected has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.