Skip to content

Moves icon dependencies to 'core' package.json - #20041

Merged
leekelleher merged 3 commits into
mainfrom
v16/feature/move-icons-to-core-package
Sep 1, 2025
Merged

Moves icon dependencies to 'core' package.json#20041
leekelleher merged 3 commits into
mainfrom
v16/feature/move-icons-to-core-package

chore(eslint): fixes eslint warnings

97213fc
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 1, 2025 in 45s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Large Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
index.js 1 advisory rule no change Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method index.js: collectDictionaryIcons

✅ Improving Code Health:

  • Complex Method index.js: collectDictionaryIcons

Annotations

Check notice on line 121 in src/Umbraco.Web.UI.Client/devops/icons/index.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Complex Method

collectDictionaryIcons is no longer above the threshold for cyclomatic complexity

Check warning on line 121 in src/Umbraco.Web.UI.Client/devops/icons/index.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

collectDictionaryIcons has 77 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.