Skip to content

Fix issue with use of EF Core scopes within notification handlers (take 2 - handling scopes with a base parent) - #19797

Merged
Migaroez merged 4 commits into
mainfrom
v16/bugfix/efcorescope-locks-with-base-parent
Jul 25, 2025
Merged

Fix issue with use of EF Core scopes within notification handlers (take 2 - handling scopes with a base parent)#19797
Migaroez merged 4 commits into
mainfrom
v16/bugfix/efcorescope-locks-with-base-parent

Fixed casing in comment.

5b74b66
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 25, 2025 in 57s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Code Duplication)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
NestedScopeTests.cs 1 advisory rule 10.00 → 9.10 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication NestedScopeTests.cs

Annotations

Check warning on line 54 in tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Scoping/NestedScopeTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 9 functions with similar structure: CanNestScopes_Core_Core,CanNestScopes_Core_EfCore_Normal,CanNestScopes_Core_Normal_Efcore,CanNestScopes_EfCore_Core_Normal and 5 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.