Conversation
AndyButland
changed the title
1 task
Moved tests alongside existing ones related to scopes. Removed long running attribute from tests (they are quite fast).
AndyButland
approved these changes
Jul 25, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
This looks good to me. I made a few minor tweaks so please check you are happy with them.
I've verified by porting this fix back to 13 that it resolves the original issue that was raised, so once we cherry-pick this back there we can close that issue.
Migaroez
added a commit
that referenced
this pull request
Jul 25, 2025
…ke 2 - handling scopes with a base parent) (#19797) * Add integration tests that shows the problem * Fix the problem and add explenation * Improved comments slightly to help when we come back here! Moved tests alongside existing ones related to scopes. Removed long running attribute from tests (they are quite fast). * Fixed casing in comment. --------- Co-authored-by: Andy Butland <abutland73@gmail.com>
Migaroez
added a commit
that referenced
this pull request
Jul 25, 2025
…ke 2 - handling scopes with a base parent) (#19797) * Add integration tests that shows the problem * Fix the problem and add explenation * Improved comments slightly to help when we come back here! Moved tests alongside existing ones related to scopes. Removed long running attribute from tests (they are quite fast). * Fixed casing in comment. --------- Co-authored-by: Andy Butland <abutland73@gmail.com>
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #18977
Description
Andy found the troublesome code in #19787 and after putting our heads together we can up with a better solution.
Testing
See manual testing steps in #19787 and the included integration tests
Todo after merge