Skip to content

V16-RC Tiptap style fixes #19473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 5 commits into from
Jun 3, 2025
Merged

V16-RC Tiptap style fixes #19473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51acbf3
Fixes search filter text alignment
leekelleher Jun 3, 2025
850fa0a
Let `styleMenu` kind display as a menu
leekelleher Jun 3, 2025
31692a5
Collapse excessive whitespace in RTE
leekelleher Jun 3, 2025
3e26334
Ensures the RTE Capabilities are in 3 columns
leekelleher Jun 3, 2025
369d24b
Dimensions UI fixes
leekelleher Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions ....Client/src/packages/property-editors/dimensions/property-editor-ui-dimensions.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import { customElement, html, property } from '@umbraco-cms/backoffice/external/lit';
import { css, customElement, html, property } from '@umbraco-cms/backoffice/external/lit';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbChangeEvent } from '@umbraco-cms/backoffice/event';
import type { UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';
Expand All @@ -25,6 +24,9 @@ export class UmbPropertyEditorUIDimensionsElement extends UmbLitElement {
return html`
<uui-input
type="number"
autocomplete="off"
min="0"
step="1"
label=${this.localize.term('general_width')}
placeholder=${this.localize.term('general_width')}
@change=${this.#onChangeWidth}
Expand All @@ -33,6 +35,9 @@ export class UmbPropertyEditorUIDimensionsElement extends UmbLitElement {
<span>&times;</span>
<uui-input
type="number"
autocomplete="off"
min="0"
step="1"
label=${this.localize.term('general_height')}
placeholder=${this.localize.term('general_height')}
@change=${this.#onChangeHeight}
Expand All @@ -42,7 +47,15 @@ export class UmbPropertyEditorUIDimensionsElement extends UmbLitElement {
`;
}

static override readonly styles = [UmbTextStyles];
static override readonly styles = [
css`
:host {
display: flex;
align-items: center;
gap: var(--uui-size-space-1);
}
`,
];
}

export { UmbPropertyEditorUIDimensionsElement as element };
Expand Down
4 changes: 0 additions & 4 deletions ...Web.UI.Client/src/packages/tiptap/components/character-map/character-map-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,10 +435,6 @@ export class UmbCharacterMapModalElement extends UmbModalBaseElement<
gap: var(--uui-size-space-4);
}

uui-input {
align-items: baseline;
}

uui-scroll-container {
height: 300px;
width: calc(450px + var(--uui-size-layout-1));
Expand Down
2 changes: 1 addition & 1 deletion ...Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
height: 100%;
width: 100%;
outline: none;
white-space: pre-wrap;
white-space: wrap;
min-width: 0;

p:first-of-type {
Expand Down
2 changes: 1 addition & 1 deletion ...y-editors/tiptap/components/property-editor-ui-tiptap-extensions-configuration.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export class UmbPropertyEditorUiTiptapExtensionsConfigurationElement
}

.group {
flex: 1;
width: calc((100% - 2rem) / 3);

ul {
list-style: none;
Expand Down
4 changes: 0 additions & 4 deletions ...ty-editors/tiptap/components/property-editor-ui-tiptap-statusbar-configuration.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,6 @@ export class UmbPropertyEditorUiTiptapStatusbarConfigurationElement
[slot='header-actions'] {
margin-bottom: var(--uui-size-2);

uui-input {
align-items: baseline;
}

uui-icon {
color: var(--uui-color-border);
}
Expand Down
5 changes: 1 addition & 4 deletions ...erty-editors/tiptap/components/property-editor-ui-tiptap-toolbar-configuration.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ export class UmbPropertyEditorUiTiptapToolbarConfigurationElement
const forbidden = !this.#context?.isExtensionEnabled(item.alias);

switch (item.kind) {
case 'styleMenu':
case 'menu':
return html`
<uui-button
Expand Down Expand Up @@ -355,10 +356,6 @@ export class UmbPropertyEditorUiTiptapToolbarConfigurationElement
[slot='header-actions'] {
margin-bottom: var(--uui-size-2);

uui-input {
align-items: baseline;
}

uui-icon {
color: var(--uui-color-border);
}
Expand Down
Loading