Skip to content

V16-RC Tiptap style fixes#19473

Merged
iOvergaard merged 5 commits intorelease/16.0from
v16/bugfix/tiptap-style-fixes
Jun 3, 2025
Merged

V16-RC Tiptap style fixes#19473
iOvergaard merged 5 commits intorelease/16.0from
v16/bugfix/tiptap-style-fixes

Conversation

@leekelleher
Copy link
Copy Markdown
Member

Description

Last minute style fixes for Tiptap RTE, (for 16-rc5).

During my Codegarden session preparation, I'd noticed a few styling issues. I suspect some of these may have come from updates in UUI, and others present a nicer UX.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies various last-minute style tweaks for the Tiptap rich-text editor UI in v16-rc5, including adding a new toolbar kind, removing outdated input alignment overrides, adjusting layout widths, updating whitespace handling, and enhancing the dimensions editor.

  • Add styleMenu support to the toolbar switch.
  • Remove redundant uui-input { align-items: baseline; } rules from multiple components.
  • Adjust layout widths in extensions, fix CSS whitespace value in the input component, and add number-input attributes plus host styling in the dimensions editor.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
property-editor-ui-tiptap-toolbar-configuration.element.ts Add styleMenu case to toolbar kind switch
property-editor-ui-tiptap-statusbar-configuration.element.ts Remove redundant uui-input alignment CSS
property-editor-ui-tiptap-extensions-configuration.element.ts Change .group from flex:1 to a fixed width
input-tiptap.element.ts Replace white-space: pre-wrap with white-space: wrap
character-map-modal.element.ts Remove redundant uui-input alignment CSS
property-editor-ui-dimensions.element.ts Add autocomplete, min, step and host styles
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts:289

  • CSS property white-space: wrap is invalid and will be ignored; consider using a valid value like normal, pre-wrap, or break-spaces instead.
white-space: wrap;

@iOvergaard iOvergaard changed the title V16 Tiptap style fixes V16-RC Tiptap style fixes Jun 3, 2025
@iOvergaard iOvergaard merged commit f70d1c0 into release/16.0 Jun 3, 2025
24 checks passed
@iOvergaard iOvergaard deleted the v16/bugfix/tiptap-style-fixes branch June 3, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants