Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies various last-minute style tweaks for the Tiptap rich-text editor UI in v16-rc5, including adding a new toolbar kind, removing outdated input alignment overrides, adjusting layout widths, updating whitespace handling, and enhancing the dimensions editor.
- Add
styleMenusupport to the toolbar switch. - Remove redundant
uui-input { align-items: baseline; }rules from multiple components. - Adjust layout widths in extensions, fix CSS whitespace value in the input component, and add number-input attributes plus host styling in the dimensions editor.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| property-editor-ui-tiptap-toolbar-configuration.element.ts | Add styleMenu case to toolbar kind switch |
| property-editor-ui-tiptap-statusbar-configuration.element.ts | Remove redundant uui-input alignment CSS |
| property-editor-ui-tiptap-extensions-configuration.element.ts | Change .group from flex:1 to a fixed width |
| input-tiptap.element.ts | Replace white-space: pre-wrap with white-space: wrap |
| character-map-modal.element.ts | Remove redundant uui-input alignment CSS |
| property-editor-ui-dimensions.element.ts | Add autocomplete, min, step and host styles |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts:289
- CSS property
white-space: wrapis invalid and will be ignored; consider using a valid value likenormal,pre-wrap, orbreak-spacesinstead.
white-space: wrap;
iOvergaard
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Last minute style fixes for Tiptap RTE, (for 16-rc5).
During my Codegarden session preparation, I'd noticed a few styling issues. I suspect some of these may have come from updates in UUI, and others present a nicer UX.