Skip to content

block grid spell out why there is no permissions UI #19198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 2 commits into from
May 2, 2025
Merged

block grid spell out why there is no permissions UI #19198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d0843
write message when no blocks available
nielslyngsoe Apr 29, 2025
ce2b885
Merge branch 'release/16.0' into v16/hotfix/block-grid-spell-out-why-…
nielslyngsoe Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...operty-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement
@state()
private _value: Array<UmbBlockGridTypeAreaTypePermission> = [];

_blockTypes: Array<UmbBlockTypeWithGroupKey> = [];
@state()
private _blockTypes?: Array<UmbBlockTypeWithGroupKey>;

@state()
private _blockTypesWithElementName: Array<{ type: UmbBlockTypeWithGroupKey; name: string }> = [];
Expand All @@ -48,7 +49,7 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement
this.observe(this.#itemsManager.items, (items) => {
this._blockTypesWithElementName = items
.map((item) => {
const blockType = this._blockTypes.find((block) => block.contentElementTypeKey === item.unique);
const blockType = this._blockTypes?.find((block) => block.contentElementTypeKey === item.unique);
if (blockType) {
return { type: blockType, name: item.name };
}
Expand Down Expand Up @@ -123,9 +124,12 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement
}

override render() {
if (this._blockTypesWithElementName.length === 0) {
if (this._blockTypes === undefined) {
return nothing;
}
if (this._blockTypesWithElementName.length === 0) {
return 'There must be one Block Type created before permissions can be configured.';
}
return html`<div id="permissions">
${repeat(
this._value,
Expand Down
Loading