Skip to content

block grid spell out why there is no permissions UI#19198

Merged
nielslyngsoe merged 2 commits intorelease/16.0from
v16/hotfix/block-grid-spell-out-why-there-is-no-permissions-ui
May 2, 2025
Merged

block grid spell out why there is no permissions UI#19198
nielslyngsoe merged 2 commits intorelease/16.0from
v16/hotfix/block-grid-spell-out-why-there-is-no-permissions-ui

Conversation

@nielslyngsoe
Copy link
Copy Markdown
Member

Today if no Block Types have been created the UI is missing for the Block Area Permissions, this writes a text about why.

image

@nielslyngsoe nielslyngsoe changed the base branch from contrib to release/16.0 April 29, 2025 19:58
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) April 29, 2025 19:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete version 1.0 endpoints and refactors API controller methods to use synchronous returns where asynchronous processing is unnecessary, while also updating related configuration and pipeline files.

  • Removed deprecated endpoints from several Media and Content API controllers.
  • Refactored async methods to return results synchronously.
  • Updated Swagger route configuration and build pipelines, and added new Azure workflows for Storybook and Backoffice deployments.

Reviewed Changes

Copilot reviewed 2305 out of 2308 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Umbraco.Cms.Api.Delivery/Controllers/Media/ByIdsMediaApiController.cs Removed obsolete v1 endpoint and refactored ItemsV20 method.
src/Umbraco.Cms.Api.Delivery/Controllers/Media/ByIdMediaApiController.cs Removed obsolete v1 endpoint and updated asynchronous handling.
src/Umbraco.Cms.Api.Delivery/Controllers/Content/QueryContentApiController.cs Removed obsolete v1 query endpoint.
src/Umbraco.Cms.Api.Delivery/Controllers/Content/ContentApiControllerBase.cs Replaced obsolete attribute with updated one.
src/Umbraco.Cms.Api.Delivery/Controllers/Content/ByRouteContentApiController.cs Removed obsolete v1 endpoint and simplified async calls.
src/Umbraco.Cms.Api.Delivery/Controllers/Content/ByIdsContentApiController.cs and ByIdContentApiController.cs Removed obsolete endpoints.
src/Umbraco.Cms.Api.Common/OpenApi/* Removed obsolete overloads and updated configuration code.
build/* and .github/workflows/* Updated and added CI/CD pipeline definitions.
NOTICES.txt Removed outdated third-party notice for TinyMCE.
Files not reviewed (3)
  • .vscode/settings.json: Language not supported
  • Directory.Build.props: Language not supported
  • Directory.Packages.props: Language not supported
Comments suppressed due to low confidence (2)

src/Umbraco.Cms.Api.Common/OpenApi/SwaggerRouteTemplatePipelineFilter.cs:44

  • Confirm that replacing the call to GetUmbracoPath with GetBackOfficePath correctly reflects the intended base URL for Swagger endpoints in all environments.
=> "${GetBackOfficePath(applicationBuilder).TrimStart(Constants.CharArrays.ForwardSlash)}/swagger/{{documentName}}/swagger.json";

src/Umbraco.Cms.Api.Delivery/Controllers/Content/ContentApiControllerBase.cs:16

  • Verify that the new attribute [ContextualizeFromAcceptHeaders] fully replaces the behavior previously provided by [LocalizeFromAcceptLanguageHeader] to ensure consistent header-based localization.
[ContextualizeFromAcceptHeaders]

@nielslyngsoe nielslyngsoe merged commit 8a98f60 into release/16.0 May 2, 2025
23 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/hotfix/block-grid-spell-out-why-there-is-no-permissions-ui branch May 2, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants