block grid spell out why there is no permissions UI#19198
Merged
nielslyngsoe merged 2 commits intorelease/16.0from May 2, 2025
Merged
Conversation
…there-is-no-permissions-ui
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete version 1.0 endpoints and refactors API controller methods to use synchronous returns where asynchronous processing is unnecessary, while also updating related configuration and pipeline files.
- Removed deprecated endpoints from several Media and Content API controllers.
- Refactored async methods to return results synchronously.
- Updated Swagger route configuration and build pipelines, and added new Azure workflows for Storybook and Backoffice deployments.
Reviewed Changes
Copilot reviewed 2305 out of 2308 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Cms.Api.Delivery/Controllers/Media/ByIdsMediaApiController.cs | Removed obsolete v1 endpoint and refactored ItemsV20 method. |
| src/Umbraco.Cms.Api.Delivery/Controllers/Media/ByIdMediaApiController.cs | Removed obsolete v1 endpoint and updated asynchronous handling. |
| src/Umbraco.Cms.Api.Delivery/Controllers/Content/QueryContentApiController.cs | Removed obsolete v1 query endpoint. |
| src/Umbraco.Cms.Api.Delivery/Controllers/Content/ContentApiControllerBase.cs | Replaced obsolete attribute with updated one. |
| src/Umbraco.Cms.Api.Delivery/Controllers/Content/ByRouteContentApiController.cs | Removed obsolete v1 endpoint and simplified async calls. |
| src/Umbraco.Cms.Api.Delivery/Controllers/Content/ByIdsContentApiController.cs and ByIdContentApiController.cs | Removed obsolete endpoints. |
| src/Umbraco.Cms.Api.Common/OpenApi/* | Removed obsolete overloads and updated configuration code. |
| build/* and .github/workflows/* | Updated and added CI/CD pipeline definitions. |
| NOTICES.txt | Removed outdated third-party notice for TinyMCE. |
Files not reviewed (3)
- .vscode/settings.json: Language not supported
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
Comments suppressed due to low confidence (2)
src/Umbraco.Cms.Api.Common/OpenApi/SwaggerRouteTemplatePipelineFilter.cs:44
- Confirm that replacing the call to GetUmbracoPath with GetBackOfficePath correctly reflects the intended base URL for Swagger endpoints in all environments.
=> "${GetBackOfficePath(applicationBuilder).TrimStart(Constants.CharArrays.ForwardSlash)}/swagger/{{documentName}}/swagger.json";
src/Umbraco.Cms.Api.Delivery/Controllers/Content/ContentApiControllerBase.cs:16
- Verify that the new attribute [ContextualizeFromAcceptHeaders] fully replaces the behavior previously provided by [LocalizeFromAcceptLanguageHeader] to ensure consistent header-based localization.
[ContextualizeFromAcceptHeaders]
src/Umbraco.Cms.Api.Delivery/Controllers/Media/ByIdsMediaApiController.cs
Show resolved
Hide resolved
madsrasmussen
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today if no Block Types have been created the UI is missing for the Block Area Permissions, this writes a text about why.