Enforce: AllowEditInvariantFromNonDefault configuration#18758
Merged
nielslyngsoe merged 14 commits intov15/feature/property-visibilityfrom Apr 1, 2025
Merged
Conversation
…edit-invariant-from-non-default
…edit-invariant-from-non-default
…edit-invariant-from-non-default
…edit-invariant-from-non-default
…edit-invariant-from-non-default
…edit-invariant-from-non-default
nielslyngsoe
approved these changes
Apr 1, 2025
…edit-invariant-from-non-default
nielslyngsoe
deleted the
v15/bugfix/allow-edit-invariant-from-non-default
branch
nielslyngsoe
added a commit
that referenced
this pull request
Apr 9, 2025
* add read only state * handle read only property state in properties element * prevent editing shared props on non default * enforce configuration * clean up * set variant id * move to property module --------- Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
madsrasmussen
added a commit
that referenced
this pull request
Apr 11, 2025
* add property visibility state manager * implement in structure manager * filter properties based on visibility * wip document type structure permissions * rename * register entity permission for document type property * add entity permission for media type property * pass fallback permissions to document granular permissions * set as preset * clean up * wip document type property picker * add preset value * Update input-document-type-structure-granular-user-permission.element.ts * move files * rename * Update input-document-value-granular-user-permission.element.ts * remove temp test * Update manifests.ts * remove unused * Update input-document-value-granular-user-permission.element.ts * rename see permission + add write permission * fix missing type * require property type unique * add unique to property type * rename to property type * map to unique * deprecate id on property type * return unique from property picker * more explicit naming * use type * render detail * Update input-document-value-granular-user-permission.element.ts * wip modal flow * clean up * add headlines * hide actions * pass preset value * add edit permission method * include property in permission name * add read and write managers * implement read and write state managers * Update content-type-structure-manager.class.ts * enforce property permissions * Storage for granular permissions at property type level * add guards * make variant property version * Rename server models to include "property" * generate server types * add permissionType to model * add mappers to user group permission data * add mapper to current user permission data * destroy * clear state * use permission type for guard check * add permission type * require specific permission type * use correct schema type * add mappings * clean up * log errors * fix mapping * null check for icon * use fallback if there is no forDataModel * add translations * sort group alphabetically * add empty state for no verbs * organize folders * always require unique and variant id * Allow storing empty lists of verbs * pass variant id to all states * Remove empty verbs * add alias to name * prevent picking the same property type multiple times * fix lint errors * fix create state by observing variant options * move to workspace context * Update document-property-value-user-permission.workspace-context.ts * Update content-editor-properties.element.ts * clean up * Rename models (last time, promise!) * Add migration for default document property value permissions * generate new server models * update after model changes * Correct the default permission identifiers * Add default permissions to newly created DBs * Add validation and clean-up * rename to visibility state * rename to view * add helpers * apply to blocks * Update document-property-value-user-permission.workspace-context.ts * disable view and write state by default * add tests for start and stopping a state * throw errors if adding to a state that is not running * export consts * export consts * fix circular * fix circular * set the entity type when setting values * only apply for block in document values * split logic * start states for document blocks * only apply states when state is running * Fixed typos in test method names. * add readonly type * Enforce: AllowEditInvariantFromNonDefault configuration (#18758) * add read only state * handle read only property state in properties element * prevent editing shared props on non default * enforce configuration * clean up * set variant id * move to property module --------- Co-authored-by: Niels Lyngsø <nsl@umbraco.dk> * remove unnecessary messages * make sure to destroy consumer * Thoughts as TODO * use Entry type * use Entry type * get rid of things not yet released * clean up * use generic methods * TODO comment * use generic observable * catch if not found * move variant id out of property type * mega refactor temp commit * Guard Manager * set readOnly as a property on property editors * further rename * remove property state managers * revert state manager * fix sorting rule * mega rename and correction * refactor properties elements * todo note * clean up * impl * mega refactor moving permission guards to workspace * rename * type change * rearrange * correct import * fix tests * correct tests * reset viewGuards block * type correction * refactor read only for user permissions setting * todo note * align property element * await promise * impl view guard property filtering * correct const name * fix fallback user permissions in mock data * correct property type id mock data * toggle permissions example * complex permission * Move migration to 16.0. * rename fallBackToDisallowed to fallbackToNotPermitted * clean up setReadOnlyStateForUserPermission * capital o * align read only naming * rename method * add js docs * remove unused * correct method name * add js docs * add js docs * camel case function * fix eslint problems * camelcase const * align method names * remove unused * fix host * fix spelling mistake * align naming * fix spelling mistake * add alias * use read only state methods * camel case function * correct method name * add js docs * camelcase function * camel case function * align method names * change method name wording * Include document property value permissions in the current user's aggregated permissions. * use is read only * delete unused * fix implementation of AllowEditInvariantFromNonDefault * don't know what is happening here. Local is it lower on github it is higher * Update document-workspace.context.ts * revert to v16 dev * simplify if statement * make it explicit that these are ui only permissions * add action label for read * remove duplicates * use read instead of browse * align description * use document instead of node * make the base class abstract * extend in test * Update guard.manager.base.test.ts * fix example * style adjustment * group styling * refactor guard rule resolving * remove imports * remove console.log * improve disconnected context consumer rejection message * fix publishableVariantsFilter * Update document-workspace.context.ts --------- Co-authored-by: Mads Rasmussen <madsr@hey.com> Co-authored-by: kjac <kja@umbraco.dk> Co-authored-by: Andy Butland <abutland73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review #18756 first