Document Property Value - Read + Write Permissions#18756
Document Property Value - Read + Write Permissions#18756madsrasmussen wants to merge 119 commits intov15/devfrom
Conversation
…5/feature/property-visibility
…5/feature/property-visibility
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
I've restricted my review to back-end code - which all looks great - and testing the feature - which also works nicely.
Spotted a related issue on the front-end - but probably not from the changes here. If you click to edit an existing document granular permission, you don't see the previous selection. Rather it's reset to the default for the group. Maybe you'll want to treat that as a separate issue though.
|
@AndyButland Thanks! Good catch. I'll look into it and create another PR so it doesn't get lost in this one. |
| private _ownerEntityType?: string; | ||
|
|
||
| @state() | ||
| _propertyViewStateIsRunning = true; |
There was a problem hiding this comment.
Maybe I'm super annoying now 😬, but shouldn't it be called read then it also corresponds well with read-only
There was a problem hiding this comment.
Are you refering to the "View state" in general?
|
@AndyButland fix PR here: #18815 |
* add read only state * handle read only property state in properties element * prevent editing shared props on non default * enforce configuration * clean up * set variant id * move to property module --------- Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
# Conflicts: # src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs # src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/schedule-publish/workspace-action/manifests.ts
|
Replace by #18997 |
4 participants
See details about the feature in the draft documentation article. It includes a description and example of how to use, extend and customize the feature.
https://github.com/umbraco/UmbracoDocs/pull/6971/files?short_path=93f9264#diff-93f9264506f9d27acf518670cb4e6ca8a55aae8a3c4baf44e59c55e5bea60ac8