Improve YSOD rendering in the client#17940
Merged
Migaroez merged 3 commits intorelease/13.6from Jan 14, 2025
Merged
Conversation
AndyButland
approved these changes
Jan 13, 2025
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Can confirm this works as described, and makes sense to at least give some useful information to the user running into the problem.
* Added timeouts * Nullcheck user in Content permission handlers (#17846) --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to fix #17909
Description
In the linked issue a screenshot was provided with a rather strange Error modal
After forcing the Authorization pipeline to fail by adding
throw new Exception("This is a forced temporary exception");to the top offUmbraco.Cms.Web.Common.Security.BackOfficeSecurity.GetUserId()I was able to get a similar Error modal. After some investigation it seems that Angular simply renders the template when the constructor of the linked controller throws an error.I have update the controller to catch the edge case where
modal.error.datais not an object but a string. And also updated the view to render more things conditionally to not clutter the modal with text that does not hold any meaning.Testing