Fix null exceptions when requesting specific content trough the backoffice APIs#17846
Merged
nikolajlauridsen merged 1 commit intov13/devfrom Jan 7, 2025
Merged
Conversation
Contributor
|
Cherry picked to 13.6 |
andr317c
added a commit
that referenced
this pull request
Jan 14, 2025
* Added timeouts * Nullcheck user in Content permission handlers (#17846) --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
Migaroez
added a commit
that referenced
this pull request
Jan 14, 2025
* Added timeouts * Nullcheck user in Content permission handlers (#17846) --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
Migaroez
added a commit
that referenced
this pull request
Jan 14, 2025
* Conditionally render error details and make sure something is rendered * V13 QA updated locator for failing E2E test (#17825) * Added timeouts * Nullcheck user in Content permission handlers (#17846) --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk> --------- Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17701
Description
As the ContentPermissions.CheckPermissions() implicetly throws an error, I chose to fix the null ref in the consuming handlers as from a AuthorizationHandler it makes sense that we have a logged in user before checking it's permissions.
Testing
Check the steps in the linked issue and keep in mind that this fix delivers a result that is in line with other Authorization Handlers failing in any way.