Skip to content

Remove parameter value/return nullability in IImageSourceParser, ILocalLinkParser and IMacroParser #15130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergmania merged 2 commits into from
Nov 6, 2023
Merged

Remove parameter value/return nullability in IImageSourceParser, ILocalLinkParser and IMacroParser #15130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16742f3
Align nullability of ILocalLinkParser with other rich text content pa…
AndyButland Nov 3, 2023
c8962d6
Remove value/return nullability in IImageSourceParser, ILocalLinkPars…
ronaldbarendse Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Umbraco.Core/Deploy/IImageSourceParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ public interface IImageSourceParser
/// <param name="dependencies">A list of dependencies.</param>
/// <returns>The parsed value.</returns>
/// <remarks>Turns src="/media/..." into src="umb://media/..." and adds the corresponding udi to the dependencies.</remarks>
string? ToArtifact(string? value, ICollection<Udi> dependencies);
string ToArtifact(string value, ICollection<Udi> dependencies);

/// <summary>
/// Parses an artifact property value and produces an Umbraco property value.
/// </summary>
/// <param name="value">The artifact property value.</param>
/// <returns>The parsed value.</returns>
/// <remarks>Turns umb://media/... into /media/....</remarks>
string? FromArtifact(string? value);
string FromArtifact(string value);
}
4 changes: 2 additions & 2 deletions src/Umbraco.Core/Deploy/IMacroParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ public interface IMacroParser
/// <param name="value">Property value.</param>
/// <param name="dependencies">A list of dependencies.</param>
/// <returns>Parsed value.</returns>
string? ToArtifact(string? value, ICollection<Udi> dependencies);
string ToArtifact(string value, ICollection<Udi> dependencies);

/// <summary>
/// Parses an artifact property value and produces an Umbraco property value.
/// </summary>
/// <param name="value">Artifact property value.</param>
/// <returns>Parsed value.</returns>
string? FromArtifact(string? value);
string FromArtifact(string value);

/// <summary>
/// Tries to replace the value of the attribute/parameter with a value containing a converted identifier.
Expand Down