Conversation
…rsers (IMacroParser and IImageSourceParser).
…er and IMacroParser
ronaldbarendse
approved these changes
Nov 6, 2023
Contributor
ronaldbarendse
left a comment
There was a problem hiding this comment.
Since we don't need to parse the value if it's null, we can avoid some methods calls by removing the nullability from the value parameter and return type (all implementations would otherwise do a if (value is null) return null; check anyway).
IImageSourceParser, ILocalLinkParser and IMacroParser
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update just aligns the nullability of the parameter and return value of the three interfaces that define parsers for rich text content. It's not essential, but nice to tidy up.
Implemented in response to this comment.
There is no implementation of this class in the CMS itself.