Skip to content

Block grid area allowance editor#14582

Merged
georgebid merged 4 commits intoumbraco:contribfrom
bjarnef:bug/block-grid-area-allowance-editor
Jul 26, 2023
Merged

Block grid area allowance editor#14582
georgebid merged 4 commits intoumbraco:contribfrom
bjarnef:bug/block-grid-area-allowance-editor

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Jul 19, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

This PR fixes a few issues in block grid area allowance editor, e.g. outline of delete button mentioned here #14518 (comment) which was because of the custom umb-outline class and that the button didn't had position: relative and it position the outline absolute

, so the closest relative element was the parent container.

actually I am not sure why we have this?

.btn.umb-outline {
position: relative
}

why not always position: relative when element as btn and umb-outline class? or maybe event moved to umb-outline class itself, because otherwise the outline would not be positioned at the element, but could be a parent container as in this case.

  • Outline of delete button
  • Missing localization of title attribute due missing @ prefix
  • Added pattern="[0-9]*" which would give a more specific numeric virtual keyboard on e.g. tablets for number input.
  • Incorrect end-closing </div>
chrome_UVVjDReFLi.mp4

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 19, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@busrasengul
Copy link
Copy Markdown
Contributor

Thank you @bjarnef
Someone from the core collabs team will look into this shortly :)

@georgebid georgebid self-assigned this Jul 25, 2023
@georgebid georgebid merged commit 1570051 into umbraco:contrib Jul 26, 2023
@georgebid
Copy link
Copy Markdown
Contributor

Hey @bjarnef nice to see this one fixed too! I have tested this and all looks good, therefore its been merged in. You should see it in the next release 🥳

@georgebid georgebid self-requested a review July 26, 2023 15:17
@bjarnef bjarnef deleted the bug/block-grid-area-allowance-editor branch July 26, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants