Block grid area allowance editor#14582
Conversation
…n some devices as we expect integer values
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Thank you @bjarnef |
|
Hey @bjarnef nice to see this one fixed too! I have tested this and all looks good, therefore its been merged in. You should see it in the next release 🥳 |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This PR fixes a few issues in block grid area allowance editor, e.g. outline of delete button mentioned here #14518 (comment) which was because of the custom
umb-outlineclass and that the button didn't hadposition: relativeand it position the outline absoluteUmbraco-CMS/src/Umbraco.Web.UI.Client/src/less/application/umb-outline.less
Line 10 in a936fe0
actually I am not sure why we have this?
Umbraco-CMS/src/Umbraco.Web.UI.Client/src/less/modals.less
Lines 122 to 124 in a936fe0
why not always
position: relativewhen element asbtnandumb-outlineclass? or maybe event moved toumb-outlineclass itself, because otherwise the outline would not be positioned at the element, but could be a parent container as in this case.Umbraco-CMS/src/Umbraco.Web.UI.Client/src/less/application/umb-outline.less
Line 6 in a936fe0
@prefixpattern="[0-9]*"which would give a more specific numeric virtual keyboard on e.g. tablets for number input.</div>chrome_UVVjDReFLi.mp4