Make it possible to remove blocks using tab key in block grid configuration#14518
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
It also looks odd how the focus on delete/remove button focus/outline parent container at "Allowed block types" in configuration of area, so I think it may be an issue with how focus/outline works on chrome_VQSwlItGx4.mp4 |
|
Thanks a lot @bjarnef, we'll have a look at it shortly! |
|
Hey @bjarnef I've tested this one and it's all looking good to me 😄 Therefore, I have merged this in. You should see it in the next release! Thanks again 🥳 |
Prerequisites
This PR fixes some issues in Block Grid configuration, which was fixed in Block List configuration, but never included in the Block Grid configuration.
Previous PR #12851 fixes issues, where blocks couldn't be removed/deleted using keyboard.
Description
This PR fixes issues deleting/removed blocks from Block Grid configuration using keyboard, which is possible in Block List configuration.
chrome_yhJKsSTNCk.mp4
There is still an issue with focus/outline, when a block as both area and delete button as the outline is on the actions element, so keyboard focus on the two button, but it isn't clear which button has focus.
Should be fixed in another PR.