Skip to content

Make it possible to remove blocks using tab key in block grid configuration#14518

Merged
georgebid merged 1 commit intoumbraco:contribfrom
bjarnef:feature/block-grid-configuration-tabs-block-cards
Jul 11, 2023
Merged

Make it possible to remove blocks using tab key in block grid configuration#14518
georgebid merged 1 commit intoumbraco:contribfrom
bjarnef:feature/block-grid-configuration-tabs-block-cards

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented Jul 6, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

This PR fixes some issues in Block Grid configuration, which was fixed in Block List configuration, but never included in the Block Grid configuration.
Previous PR #12851 fixes issues, where blocks couldn't be removed/deleted using keyboard.

Description

This PR fixes issues deleting/removed blocks from Block Grid configuration using keyboard, which is possible in Block List configuration.

chrome_yhJKsSTNCk.mp4

There is still an issue with focus/outline, when a block as both area and delete button as the outline is on the actions element, so keyboard focus on the two button, but it isn't clear which button has focus.
Should be fixed in another PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 6, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Copy Markdown
Contributor Author

bjarnef commented Jul 6, 2023

It also looks odd how the focus on delete/remove button focus/outline parent container at "Allowed block types" in configuration of area, so I think it may be an issue with how focus/outline works on <umb-button> component.

chrome_VQSwlItGx4.mp4

@mikecp
Copy link
Copy Markdown
Contributor

mikecp commented Jul 9, 2023

Thanks a lot @bjarnef, we'll have a look at it shortly!

@georgebid georgebid self-assigned this Jul 11, 2023
@georgebid georgebid merged commit 2b62969 into umbraco:contrib Jul 11, 2023
@georgebid
Copy link
Copy Markdown
Contributor

Hey @bjarnef I've tested this one and it's all looking good to me 😄 Therefore, I have merged this in. You should see it in the next release! Thanks again 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants