Hotfix: create and pack empty file to add TFM dependency to Umbraco.Cms and Umbraco.Cms.Targets#13502
Closed
ronaldbarendse wants to merge 1 commit intorelease/11.0from
Closed
Hotfix: create and pack empty file to add TFM dependency to Umbraco.Cms and Umbraco.Cms.Targets#13502ronaldbarendse wants to merge 1 commit intorelease/11.0from
ronaldbarendse wants to merge 1 commit intorelease/11.0from
Conversation
Contributor
Author
|
With this in place, trying to install Otherwise it will install successfully, but not pull any dependencies into the project (as those are .NET 7 specific) and probably result in some confusion as to why Umbraco isn't working. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
PR #13475 added an MSBuild target that added an empty file in a framework specific folder to the
Umbraco.CmsandUmbraco.Cms.Targetsmeta-packages, so they can only be installed into projects with a compatible TFM.This worked fine if the package was created using
dotnet pack, but the target wasn't executed when doing a separatedotnet buildanddotnet pack --no-build(as done by the build pipeline), causing the file to not be included.This fixes this problem and only executes the target when the NuGet package is actually created, so it also doesn't have to write the empty file when only doing a build (reducing disk I/O).