Skip to content

Item tracking fixes and optimizations after RC#12146

Merged
bergmania merged 8 commits intov9/devfrom
v9/bugfix/item-tracking-fixes
Mar 18, 2022
Merged

Item tracking fixes and optimizations after RC#12146
bergmania merged 8 commits intov9/devfrom
v9/bugfix/item-tracking-fixes

Conversation

@elit0451
Copy link
Contributor

@elit0451 elit0451 commented Mar 17, 2022

Details

This PR fixes some of the issues mentioned as comments in #11919, together with a bug where duplicate items were displayed on the items tracking result:

  • Adding xdoc comments on public interfaces;
  • Fixing some wording and other minor fixes;
  • Removing duplicate items when displaying references;
  • Optimization - only load references when you navigate to the Info app.

Test

  • Reference the same items in several different places;
  • Make sure all the references appear;
  • Make sure that when this item is part of bulk deletion/unpublishing or when deleting/unpublishing the parent of the item, it doesn't appear several times in the result since it has more than 1 reference.

@elit0451 elit0451 marked this pull request as ready for review March 17, 2022 15:34
@bergmania bergmania merged commit 3044f8d into v9/dev Mar 18, 2022
@bergmania bergmania deleted the v9/bugfix/item-tracking-fixes branch March 18, 2022 10:21
@bergmania bergmania changed the title Item tracking fixes Item tracking fixes and optimizations after RC Mar 18, 2022
@bergmania
Copy link
Member

Cherry picked for 9.4

nikolajlauridsen pushed a commit that referenced this pull request Mar 23, 2022
* Cleanup; Fix lang keys

* Documentation

* Typos

* Distinct the results

* Changed GetPagedRelationsForItems to GetPagedRelationsForItem as we would only expect a single id to be passed when calling this + fix more docs

* Changed to the correct reference

* Unused code

* Only load references when info tab is clicked

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants