Conversation
…9/feature/item-tracking
…9/feature/item-tracking
…ted select instead of inner join).
…m/umbraco/Umbraco-CMS into v9/feature/item-tracking-refactor
…r' into v9/feature/item-tracking
|
|
||
| function enableUser() { | ||
| vm.enableUserButtonState = "busy"; | ||
| vm.enableUserButtonState = "busfy"; |
There was a problem hiding this comment.
@nielslyngsoe shouldn't this be busy as in commit message "rename busfy to busy"?
https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Web.UI.Client/src/views/users/user.controller.js#L377
Besides that I can't see the vm.enableUserButtonState or vm.enableUser() function is being used in user.html - only vm.enableUserButtonState and vm.enableUsers() in users.html
There was a problem hiding this comment.
I've renamed busfy to busy but will let @nielslyngsoe answer the other question 😊
|
|
||
| sql.WhereIn<RelationDto>(rel => rel.ChildId, itemIds); | ||
| sql.Where<RelationDto, NodeDto>((rel, node) => rel.ChildId == node.NodeId); | ||
| sql.Where<RelationTypeDto>(type => type.IsDependency); |
There was a problem hiding this comment.
This query would benefit from an index on ChildId, IsDependency on RelationDto
There was a problem hiding this comment.
Good point.. Will create task for that
There was a problem hiding this comment.
RelationRepository.GetPagedEntitiesForItemsInRelation is not used as the logic has been moved to a different repo but we will create the indexes as they are still useful for the use case 👍
There was a problem hiding this comment.
The new place where we are making a similar query is TrackedReferencesRepository.GetPagedItemsWithRelations(). When testing we didn't see major improvements adding the indexes. Can you perhaps elaborate on the reasons for your suggestion? 🙂
src/Umbraco.Core/Persistence/Repositories/ITrackedReferencesRepository.cs
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TrackedReferencesRepository.cs
Show resolved
Hide resolved
|
Thanks both for the suggestions! 💪 Most of them, together with additional fixes can be found in #12146 |
Details
This PR's purpose is to begin the process of integrating the functionality of the Nexu package directly into Umbraco 9.
The whole feature request can be found here.
@dawoe had already worked on 5/8 of the items on the TODO List for v8, and this PR migrates those to v9.
More specifically:
This PR also adds the last 3 features from the list, related to warning the user when performing listview bulk actions:
Tests
vm.contentOptions.pageSize = 5in umbtrackedreferences.component.js loadContentRelations()vm.mediaOptions.pageSize = 5;in umbtrackedreferenceslistview.component.js checkMediaListViewUsage()Update: