Inherit text color from parent element

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

After PR #10805 was merged I noticed block card didn't show the selected icon color.

The icon name includes color class as well, which is a bit of a mess and color classes are forcing color with !important as well. Furthermore the inline color style need !important as well to overwrite this 🙀

I could continue the trend with another !important rule as in bc5a381 to inherit the correct color as well in <umb-icon> component.

However I think this would be just another hack.

Instead it should just include the icon and furthermore we don't need to use !important on the inline style to get the correct color.

[umbrabot]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nathanwoulfe]

All good @bjarnef, removing !important is always a good thing.

I made a minor change in the component js, to use an interpolated string when setting styleBackgroundImage, since that removes the need to escape the quotes, which makes for an easier-to-read value:

'url(\'' + path + '\')' => `url('${path}')`