Skip to content

Regional restart regression test fixed#918

Merged
junwang-noaa merged 26 commits into
ufs-community:developfrom
RatkoVasic-NOAA:debug_RT
Dec 1, 2021
Merged

Regional restart regression test fixed#918
junwang-noaa merged 26 commits into
ufs-community:developfrom
RatkoVasic-NOAA:debug_RT

Conversation

@RatkoVasic-NOAA
Copy link
Copy Markdown
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Nov 17, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Fixed regional regression tests wrt restart. Additionally renamed and corrected regional tests.
Fixed the issue of the accumulation bucket FHZERO impacting resulting forecast.

Results are changed.

Issue(s) addressed

Testing

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3 (no access)
  • opnReqTest for newly added/changed feature (with the FHZEO fix)
  • CI

Dependencies:

fv3atm PR #425
CCPP PR #779

@junwang-noaa
Copy link
Copy Markdown
Collaborator

@RatkoVasic-NOAA Thanks for fixing the restart test!

@junwang-noaa junwang-noaa added Baseline Updates Current baselines will be updated. hera-gnu-BL labels Dec 1, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/782288563/20211201001512/ufs-weather-model
Please make changes and add the following label back:
hera-gnu-BL

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I noticed the CI tests failed again.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

Approved. I noticed the CI tests failed again.

CI failed for regional tests because of the changed write component PEs. This will be fixed in #927.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

Approved. I noticed the CI tests failed again.

CI failed for regional tests because of the changed write component PEs. This will be fixed in #927.

There are many hard coded values in model_configure_regional.IN, including write_tasks_per_group: 8. Ideally, these should be done through export variables; something to think about in the future.

@junwang-noaa junwang-noaa merged commit b884a61 into ufs-community:develop Dec 1, 2021
@RatkoVasic-NOAA
Copy link
Copy Markdown
Collaborator Author

@MinsukJi-NOAA which variables in model_configure_regional.IN would you like to put as a passing argument (other than mentioned write_tasks_per_group)?
Since it is easy fix, do you want me to change it, or you will do it?

@RatkoVasic-NOAA RatkoVasic-NOAA deleted the debug_RT branch December 1, 2021 18:33
@climbfuji climbfuji mentioned this pull request Dec 2, 2021
16 tasks
JianpingHuang-NOAA added a commit to JianpingHuang-NOAA/ufs-weather-model that referenced this pull request Oct 5, 2023
…res associated with missing RAVE files (ufs-community#918)

* create a feature branch to address EE2 compliance

* update job_preamble.sh and config_defaults.yaml to address AQMv7 EE2 compliance

* add changes to fix recent two NRT runs' failures due to incorrect RAVE files and add a dummy file to deal with the case of missing RAVE files

* to address PR918 reviewrs' comments

* update exrefional_aqm_lbcs.sh for retro run

* to address reviewer's comments on PR918

* modify config_defaults.yaml generate_FV3LAM_wflow.py link_fix.py and wcoss2.yaml

* update wcoss2 and config.aqm.nco.realtime files with jianping.huang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FHZERO bug

6 participants