Noah MP updates for Prototype 8 (GFSv17)#927
Conversation
…urface_fields Inline post for additional surface fields
…urface_fields modification for addtional land outputs
update the github path for ccpp-physics repository
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
Please update BL_DATE in rt.sh. |
|
Compilation fails with this error message: |
I was expecting something like this, and I have more questions on that variable - |
|
Sorry. I accidentally removed this variable from the argument list when I
did the code cleanup this morning. I have added it back with this commit
<HelinWei-NOAA/ccpp-physics@8867777>
…On Mon, Nov 29, 2021 at 3:16 PM Dom Heinzeller ***@***.***> wrote:
Compilation fails with this error message:
+ make -j 8 VERBOSE=1
/gpfs/hps3/emc/meso/save/Dusan.Jovic/ufs/pr927/ufs-weather-model/FV3/ccpp/physics/physics/GFS_surface_generic.F90(294): error #6451: A dummy argument name is required in this context. [DTF]
real(kind=kind_phys), intent(in) :: dtf
--------------------------------------------------------------^
compilation aborted for /gpfs/hps3/emc/meso/save/Dusan.Jovic/ufs/pr927/ufs-weather-model/FV3/ccpp/physics/physics/GFS_surface_generic.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/physics/GFS_surface_generic.F90.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
I was expecting something like this, and I have more questions on that
variable - dtf was removed from the argument list, but neither the
declaration that Dusan pointed out nor the entry in the CCPP metadata was
removed. This shouldn't compile (and it doesn't). @grantfirl
<https://github.com/grantfirl> FYI
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#927 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALPHKYBPT4GIT2EM4TNMDV3UOPNR5ANCNFSM5IM5QGWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@HelinWei-NOAA Please update your fv3atm branch and then your ufs-weather-model branch. |
|
I will make a PR to @HelinWei-NOAA's branch for the regional CI fix. |
Fix CI for regional tests
I just merged this PR to my branch. |
|
WCOSS RT log files: @HelinWei-NOAA please commit these two log files |
done |
7 participants
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
fv3atm PR 387
ccpp-physics PR 729
UPP PR 378
All results will be changed because of the modified physics and extra fields in the model output
New diag_table is needed for those extra land ouputs
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
LAND FRACTION
INST PREC ADVEC HEAT
WATER IN AQUIFER
ACM EIWATER(CANOPY WATER EVAPORATION)
ACM PLANTTR( PLANT TRANSPIRATION)
ACM SOILSE (BARE SOIL EVAPORATION)
AVE PREC ADVEC HEAT
GFS surface layer scheme is added to the Noah MP surface layer option.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
No.
If so add the "waiting for other repos" label and list the upstream PRs