Skip to content

update templates for diag_table to be consistent with model_configure#759

Closed
aerorahul wants to merge 12 commits into
ufs-community:developfrom
aerorahul:feature/diag_template_update
Closed

update templates for diag_table to be consistent with model_configure#759
aerorahul wants to merge 12 commits into
ufs-community:developfrom
aerorahul:feature/diag_template_update

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories. There is no change to the sub-components associated with this PR.

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. See issue move diag_table/field_table from input directory to tests/parm in the repository  #644

Description

The diag_table templates (and other e.g. MOM6, WW3, ICE) employ different templating than the ones used in input.nml, model_configure and nems.configure. These files use the template defined via @[VARIABLE] which is replaced by $VARIABLE defined upstream.

The workflow team would like to use the templates from the UFS-weather-model for constructing the necessary input files.
This will allow the workflow and the model to use the same templates, albeit filled with application specific values for the templated variables.

No change of answers is expected from this PR.
There is no impact on the general user running regression tests.
There are no library or modulefiles updated or need changes with this PR.

Issue(s) addressed

Testing

These have not been tested by running the model on any platform in particular with the exception that the change produces the desired output diag_file from the template as before.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

None.

@aerorahul aerorahul self-assigned this Aug 20, 2021
@aerorahul aerorahul added the enhancement New feature or request label Aug 20, 2021
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@aerorahul Just FYI, the "templating" files were initially introduced when S2S was being run using the Python based CompsetRunner that Sam built. They are overdue for updating to whatever works best now that all applications are using the rt.sh infrastructure.

@aerorahul aerorahul marked this pull request as ready for review August 20, 2021 16:40
…sics (was PR #755) (#756)


* update CICE for added memory profiling
* update stochastic_physics for memory fix leak

co-authors: @lisa-bengtsson , @pjpegion
Comment thread tests/edit_inputs.sh Outdated
bensonr and others added 10 commits August 25, 2021 09:36
* updated fv3atm
* updated fv3_conf/compile_slurm.IN_gaea to use proper queue with ecflow
* updated ufs_common modulefiles to use newly installed FMS 2021.03 library
…ublic release (#772)

This PR brings in an update for fv3atm that contains updates to the latest public release of the FV3 dycore. This PR changes answers for all regional tests and any test with ICs created by chgres from sources that sets the data_source_fv3gfs=.true. option in FV3/atmos_cubed_sphere/tools/external_ic.F90::get_nggps_ic routine. 
* updated ICs to use newly created 20210825 snapshot
* bypass control_csawmg test for gaea (numerical instability)
* updated BL_DATE in anticipation of baseline creation
* use fms lib built with avx on hera, update baseline date
@aerorahul
Copy link
Copy Markdown
Contributor Author

Github PR shows 29 files changed, when there are only 5 actually changed.
Closing and reopening this PR.

@aerorahul aerorahul closed this Aug 31, 2021
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…lues (#759)

* Modify RRFS North America 3- and 13-km domain configuration and WE2E test.

* Modify default ISEED values for SPP

* Fix grid in WE2E test
zhanglikate pushed a commit to zhanglikate/ufs-weather-model that referenced this pull request Oct 20, 2025
…unity#759)

Add doxygen to the cmake build and add doxygen build to CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants