Address memory leak in cellular automaton scheme#755
Closed
lisa-bengtsson wants to merge 2 commits into
Closed
Conversation
This was referenced Aug 20, 2021
Closed
|
@lisa-bengtsson please bring these up to date with respective authoritative repositories
|
Collaborator
|
Code will be committed as part of PR #756 |
DeniseWorthen
added a commit
that referenced
this pull request
Aug 23, 2021
…sics (was PR #755) (#756) * update CICE for added memory profiling * update stochastic_physics for memory fix leak co-authors: @lisa-bengtsson , @pjpegion
zhanglikate
pushed a commit
to zhanglikate/ufs-weather-model
that referenced
this pull request
Oct 20, 2025
…nity#755) * Moving nest performance optimization stage 2. * update atmos_model and FV3GFS_io read performance when io_layout=1,1 and allow one to override data integrity checks in FMS restart logic * Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @BinLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml * Update submodule upp, which has the fix for regional latlon grid crossing the prime meridian. * Only call atmosphere_fill_nest_cpl at the cap driver time steps (coupling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest. * Removed reference to unused variable parent_x. * Update to point submodule ccpp/physics to the feature/hafsv0.3_final branch of the hafs-community fork. * FV3-related typedefs changes for the Hurricane PBL options * Update submodule ccpp/physics, which added the tc_pbl option in the GFS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling. * Update to point the support/HAFS branch for upp, ccpp-physics and atmos_cubed_sphere. * Adding upoff as a namelist parameter * Update submodule atmos_cubed_sphere, which has updated the time string in internal tracker output (fort.602, phtcf file). * fix initialization issue for moving nest grid in debug mode (ufs-community#622) * Update submodule atmos_cubed_sphere to point the production/hafs.v1 branch. * Update submodule upp, which cherry-picked the wind GUST fix from the develop branch. * Create ESMF field attributes using the same kind as field data values (ufs-community#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes * Update ccpp/suites_not_used/suite_FV3_HAFS_v1* files, needed for the latest sync. * Update submodule UPP to point to the feature/hafsv2_baseline branch. * Add a namelist to include ocean current in the computation of air-sea fluxes. * Change the variable name for zonal ocean current from ssu to usfco. * Change the variable name for meridional ocean current from ssv to vsfco. * Update HAFS thompson ccpp suites and move suite_FV3_HAFS_v1_thompson.xml and suite_FV3_HAFS_v1_thompson_nonsst.xml under ccpp/suites since they are used by operational HAFS configurations. * Update usfco and vsfco standard and long names in GFS_typedefs.meta. * Update standard name for icplocn2atm in ccpp/data/GFS_typedefs.meta. --------- Co-authored-by: Bin.Liu <Bin.Liu@noaa.gov> Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov> Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov> Co-authored-by: AndrewHazelton <andrew.hazelton@noaa.gov> Co-authored-by: Biju Thomas <biju.thomas@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Bugfix for memory leak in cellular automaton scheme
Issue(s) addressed
Issue 746
Testing
Runs with UFS tagged P7c confirmed memory leak is fixed with this update, as well as unit tests with CA scheme on Hera.
Dependencies
Do PRs in upstream repositories need to be merged first?
NOAA-PSL/stochastic_physics#44