Merge HAFS coupling related developments back to ufs-weather-model#715
Merged
DusanJovic-NOAA merged 367 commits intoAug 5, 2021
Merged
Conversation
…re/hafs_couplehycom
…ysics_from_hafs_community dtc/hwrf-physics: update from HAFS community
Updates for hwrf_sfc_PR from Dom
UFS testing for HWRF Noah and GFDL surface layer
…v0_gfdlmp_nocpugwd.xml.
…re/hafs_couplehycom
feature. Update ESMF library to version 8.1.0bs19.
…re/hafs_couplehycom
…responding support/HAFS branches.
…e_update_20200611 dtc/hwrf-physics: hera/jet module environment update
…ysics_from_hafs_support_20200618 dtc/hwrf-physics: update from support/hafs 2020/06/18 These code changes have been approved previously when merged into the authoritative branches (which were then brought to support/HAFS). Merging without approval.
BinLiu-NOAA
requested review from
aerorahul,
evankalina,
junwang-noaa and
uturuncoglu
BinLiu-NOAA
force-pushed
the
feature/hafs_sync_202107
branch
from
9b15bad to
5bfb2d3
Compare
junwang-noaa
reviewed
Aug 5, 2021
junwang-noaa
approved these changes
Aug 5, 2021
aerorahul
approved these changes
Aug 5, 2021
Collaborator
|
I don't see CMEPS pointing to the right hash yet. Should be pointing to NOAA-emc, emc/develop, hash 7d7c066 |
BrianCurtis-NOAA
approved these changes
Aug 5, 2021
Collaborator
I see CMEPS does point to 7d7c066. Please double check. |
Collaborator
|
Thanks Dusan. I sometimes have trouble w/ the "files changed" view showing me the actual most recent changes. |
DeniseWorthen
approved these changes
Aug 5, 2021
climbfuji
approved these changes
Aug 5, 2021
DusanJovic-NOAA
approved these changes
Aug 5, 2021
This was referenced Aug 5, 2021
BinLiu-NOAA
added a commit
to hafs-community/HAFS
that referenced
this pull request
Aug 13, 2021
Sync HAFS submodules with their corresponding authoritative branches: - hafs_forecast.fd as of 08/05/2021 - hafs_gsi.fd as of 08/06/2021 plus the dual-resolution 3DEnVar bug fix - hafs_post.fd as of 08/02/2021 - hafs_utils.fd as of as of 07/23/2021 - hafs_graphics.fd/hrd_gplot as of 08/10/2021 - hafs_graphics.fd/emc_graphics as of 08/10/2021 Besides application level changes were made accordingly with the updated submodules. This PR addresses issue #80. Notes: - The [bug of wrong Time dimension in FV3 restart sfc_data files](NOAA-EMC/ufsatm#344) has been fixed in ufs-weather-model through this ufs-weather-model [PR](ufs-community/ufs-weather-model#702). - The bug fix in for the dual-resolution EnVar analysis in GSI (hafs_gsi.fd) contributed from OU collaborators has also been included in this PR. With that the HAFS ENSDA configurations can now work properly. - As for the hafs_forecast.fd submodule, support/HAFS branch is identical to the ufs-weather-model develop branch as of 08/05/2021. More information can be found through this PR (ufs-community/ufs-weather-model#715)
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
The "," separated words in the bash case statement of file devbuild.sh does not work on MacOS Monterey and bash version 5.2.15. For generality, it had better use "|" to separate words in the bash case statement.
zhanglikate
pushed a commit
to zhanglikate/ufs-weather-model
that referenced
this pull request
Oct 20, 2025
* new global_nest_v1 suite * switch to ugwpv1 in global_nest_v1 suite * update suite_FV3_global_nest_v1.xml for scheme rename/rearrangement * point to lisa/C3_updates --------- Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
With the great collaboration among NESII/EMC/AOML/DTC, the HAFS coupling related development reached a few major milestones, for which we think they can be merged/integrated back to the ufs-weather-model develop branch. More specifically, the following developments/enhancements are ready for going back to ufs-weather-model develop branch:
This PR does not change answers for the existing ufs-weather-model standard regression tests. However, the following five HAFS related regression tests will be added into the standard regression tests.
To run these additional regression tests, the following input-data sub directories will need to staged to all ufs-weather-model supported platforms, and correspondingly the new baseline for these additional regression tests should also be added and staged.
On Orion under: /work/noaa/nems/bliu/RT/NEMSfv3gfs/input-data-20210717/
DATM_ERA5_input_data DOCN_MOM6_input_data DOCN_OISST_input_data FV3_hafs_regional_input_data HYCOM_regional_input_data
Issue(s) addressed
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Currently, this feature branch has been synced with the latest ufs-weather-model develop and its submodules. And all ufs-weather-model existing standard regression tests passed on Orion and Hera. Baselines for the newly added HAFS RTs have been generated and full regression tests have passed on all supported platforms as listed above.
Dependencies
Contributors
NESII: @danrosen25, @uturuncoglu, @rsdunlapiv
EMC: @BinLiu-NOAA, @ChunxiZhang-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @JunghoonShin-NOAA, @ZhanZhang-NOAA and the whole EMC Hurricane Project team; @JessicaMeixner-NOAA and @aliabdolali from the EMC Wave Modeling team
AOML: @hyunsookkim-NOAA, @AndrewHazelton
DTC: @evankalina
and other UFS HAFS Application Team collaborators