Skip to content

add control_c384gdas_wav and control_atmwav tests#620

Merged
DeniseWorthen merged 51 commits into
ufs-community:developfrom
aliabdolali:fb_add_control_wave_tests
Jul 30, 2021
Merged

add control_c384gdas_wav and control_atmwav tests#620
DeniseWorthen merged 51 commits into
ufs-community:developfrom
aliabdolali:fb_add_control_wave_tests

Conversation

@aliabdolali
Copy link
Copy Markdown
Collaborator

@aliabdolali aliabdolali commented Jun 4, 2021

This pull request updates the control tests:

  • control_atmwav (modified)
  • control_c384gdas_wav (added)
  • The WW3 model is updated with the top of NOAA/Develop
  • NOAA-EMC/WW3@3740ba9

The new grids, mod_defs and rmp_src* for gfsv16 are added to the input-data-20210614/WW3_input_data_20210621 on hera and orion.

new baselines are needed.

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Comment thread tests/parm/control_gdas_wav.nml.IN Outdated
@DeniseWorthen DeniseWorthen self-assigned this Jun 22, 2021
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@aliabdolali Please remove the additional control_gdas_wav.nml.IN and instead use a variable in the default test control_gdas.nml.IN

+  cplwav       = @[CPLWAV]

CPLWAV is false by default, so in your new test control_c384gdas_wav set CPLWAV=.true. and change the namelist name that the test uses.

@aliabdolali
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen
I am working on it, thanks

@aliabdolali
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen I did the suggested changes and tested them.

Comment thread tests/tests/control_c384gdas_wav
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

changes look good.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@aliabdolali We may be moving the commit date for this PR up, depending on the status of Moorthi's PR. Have you added the WW3_input_data_20210518 to additional platforms ?

Which platforms do you not have access to that you would need me to do that?

@aliabdolali
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen I was waiting for ufs-weather-model team to give me the time to start running final test and add log files. I have the inputs on hera and can add them to orion and run on these 2 platforms.
I also got WCOSS access recently, but have not run anything on it, and probably do not have write permission?
Could you tell me if this is the time to start, so I can copy inputs to orion, and run on hera and orion with intel?

@aliabdolali
Copy link
Copy Markdown
Collaborator Author

@DeniseWorthen On another note, since we have two new tests, do I need to create a new baseline?
rt.sh -c -e rt.conf?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

We need to have the data added across all platforms before we begin testing but we should do it ahead of time so we're ready to go. I won't know exactly when we can start the commit process until later today---it depends on how far Moorthi gets on resolving the issues with his PR.

I will add the needed WW3 input across platforms since you have limited access. There is no wcoss-dell access right now so that will need to wait.

For the new baseline, yes, we will need to create a new baseline for that single test. Since you're updating WW3 also it might be best to create all new baselines even though you expect no change from the WW3 change alone.

@aliabdolali
Copy link
Copy Markdown
Collaborator Author

aliabdolali commented Jun 23, 2021

@DeniseWorthen I just transferred the inputs to Orion
/work/noaa/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20210614/WW3_input_data_20210621

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@aliabdolali Please update the BL_DATE in rt.sh to today's date and commit that change. We we will use the auto-BL creation feature; WCOSS needs to be run manually but we will need to wait for access.

@DeniseWorthen DeniseWorthen added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Jun 23, 2021
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Machine: hera
Compiler: gnu
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/661779909/20210623200042/ufs-weather-model
Please make changes and add the following label back:
hera-gnu-BL

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Machine: hera
Compiler: intel
Job: BL
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/661779909/20210623200529/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_293168
Test control_c384gdas_wav 081 failed failed
Test control_c384gdas_wav 081 failed in run_test failed
Test control_atmwav 080 failed in check_result failed
Test control_atmwav 080 failed in run_test failed
Please make changes and add the following label back:
hera-intel-BL

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

DeniseWorthen commented Jun 23, 2021

@aliabdolali Please check the run directory /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_293168 for the failures. The 384gdas test failed with

312:
312:                     *** WAVEWATCH III Multi-grid shell ***
312:                =================================================
312:
321:
321: EXTCDE MPI_ABORT, IEXIT=  2000

The control_atmwav test failed because it did not find these files:

 Moving out_grd.glo_1deg .........NOT OK. Missing  /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_293168/control_atmwav/out_grd.glo_1deg
 Moving out_pnt.points .........NOT OK. Missing  /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_293168/control_atmwav/out_pnt.points

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@aliabdolali Please update the baseline date in rt.sh

update baseline date to BL_DATE=20210729
Comment thread tests/tests/control_c384gdas_wav
Comment thread tests/default_vars.sh
@DeniseWorthen DeniseWorthen merged commit ddcd809 into ufs-community:develop Jul 30, 2021
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Change fvcom_to_FV3 use to allow for warm/cold start sfc data and time selection in a FVCOM file

* Update valid values for FVCOM_WCSTART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants