add control_c384gdas_wav and control_atmwav tests#620
Conversation
|
@aliabdolali Please remove the additional CPLWAV is false by default, so in your new test |
|
@DeniseWorthen |
|
@DeniseWorthen I did the suggested changes and tested them. |
|
changes look good. |
|
@aliabdolali We may be moving the commit date for this PR up, depending on the status of Moorthi's PR. Have you added the WW3_input_data_20210518 to additional platforms ? Which platforms do you not have access to that you would need me to do that? |
|
@DeniseWorthen I was waiting for ufs-weather-model team to give me the time to start running final test and add log files. I have the inputs on hera and can add them to orion and run on these 2 platforms. |
|
@DeniseWorthen On another note, since we have two new tests, do I need to create a new baseline? |
|
We need to have the data added across all platforms before we begin testing but we should do it ahead of time so we're ready to go. I won't know exactly when we can start the commit process until later today---it depends on how far Moorthi gets on resolving the issues with his PR. I will add the needed WW3 input across platforms since you have limited access. There is no wcoss-dell access right now so that will need to wait. For the new baseline, yes, we will need to create a new baseline for that single test. Since you're updating WW3 also it might be best to create all new baselines even though you expect no change from the WW3 change alone. |
|
@DeniseWorthen I just transferred the inputs to Orion |
|
@aliabdolali Please update the BL_DATE in rt.sh to today's date and commit that change. We we will use the auto-BL creation feature; WCOSS needs to be run manually but we will need to wait for access. |
|
Machine: hera |
|
Machine: hera |
|
@aliabdolali Please check the run directory The control_atmwav test failed because it did not find these files: |
|
@aliabdolali Please update the baseline date in rt.sh |
update baseline date to BL_DATE=20210729
* Change fvcom_to_FV3 use to allow for warm/cold start sfc data and time selection in a FVCOM file * Update valid values for FVCOM_WCSTART
This pull request updates the control tests:
The new grids, mod_defs and rmp_src* for gfsv16 are added to the input-data-20210614/WW3_input_data_20210621 on hera and orion.
new baselines are needed.
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)