Feature/pratemax#594
Closed
ericaligo-NOAA wants to merge 26 commits into
Closed
Conversation
Merge remote-tracking branch 'origin/develop' into feature/pratemax
This was referenced Jun 9, 2021
junwang-noaa
requested changes
Jun 14, 2021
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Eric, my understanding is that you only changed the fv3 and ccpp/physics in order to output pratemax. It looks to me the CDEPS, CICE, CMEPS and ww3 are not up to date yet, please sync with the top of ufs-weather-model develop branch.
Collaborator
Author
|
Hi, yes, you're correct. I did a git merge origin/develop this morning
in ufs-weather-model. It always fails for some of those you listed so I
do a git add, commit and push. Is that not right?
…On 6/14/2021 9:20 AM, Jun Wang wrote:
***@***.**** requested changes on this pull request.
Eric, my understanding is that you only changed the fv3 and
ccpp/physics in order to output pratemax. It looks to me the CDEPS,
CICE, CMEPS and ww3 are not up to date yet, please sync with the top
of ufs-weather-model develop branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#594 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJNZXZ5NICBB6HPGK3TSX6ZZANCNFSM45OCEDWQ>.
|
DusanJovic-NOAA
added
Baseline Updates
|
@ericaligo-NOAA please bring these up to date with respective authoritative repositories
|
1 similar comment
|
@ericaligo-NOAA please bring these up to date with respective authoritative repositories
|
Collaborator
Author
|
I thought they were. Please provide detailed instructions on how I
should do that. Thanks.
…On 6/14/2021 9:51 AM, github-actions[bot] wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> please bring these
up to date with respective authoritative repositories
* cice *NOT* up to date
* ww3 *NOT* up to date
* cmeps *NOT* up to date
* cdeps *NOT* up to date
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#594 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MLK37O2LL2LKZDVWQ3TSYCO7ANCNFSM45OCEDWQ>.
|
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model
that referenced
this pull request
Apr 4, 2023
* Add a new SDF named FV3_WoFS_v0 for SRW_v2.1 release * Minor bug fix to add variable nf_albd in the host model data structure (CCPP_typedefs.F90)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review
PR Checklist
#576
Only standalone model (regional configurations) should include a new field in the diag_table:
"gfs_phys", "pratemax", "pratemax", "fv3_history2d", "all", .false., "none", 2
Description
This PR adds the hourly maximum precipitation rate in mm/hr for all microphysical schemes and will be used only by regional configurations. Results for regional configurations will change because pratemax, as noted above, will be added to the diag_table. Global configurations will not use pratemax, therefore, results would be unchanged.
Issue(s) addressed
#576
Testing
Tested on hera with intel. New baseline was created for the regional configuration and a 2nd RT was run to confirm bit identical results. For global applications, no new baseline was created and results were bit identical.
Dependencies
fv3atm,ccpp/physics
NOAA-EMC/ufsatm#327
NCAR/ccpp-physics#675