Feature/pratemax#675
Merged
Conversation
ericaligo-NOAA
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
climbfuji
approved these changes
Jun 9, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Straightforward. Please add links to the ufs-weather-model and fv3atm PRs in the dependencies section of the PR description.
This was referenced Jun 9, 2021
10 tasks
JohanaRomeroAlvarez
pushed a commit
to JohanaRomeroAlvarez/ccpp-physics
that referenced
this pull request
Sep 8, 2025
* switch sign on mean momentum fluxes * send mean momentum fluxes to mediator w/ correct sign for coupling * fix variable alignment in module_block_data * change sign of exported sensible heat flux * add evap fields for atm export * change sign for exported latent heat flux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
ufs-community/ufs-weather-model#576
Only standalone model (regional configurations) should include a new field in the diag_table:
"gfs_phys", "pratemax", "pratemax", "fv3_history2d", "all", .false., "none", 2
Description
This PR adds the hourly maximum precipitation rate in mm/hr for all microphysical schemes and will be used only by regional configurations. Results for regional configurations will change because pratemax, as noted above, will be added to the diag_table. Global configurations will not use pratemax, therefore, results would be unchanged.
Issue(s) addressed
ufs-community/ufs-weather-model#576
Testing
Tested on hera with intel. New baseline was created for the regional configuration and a 2nd RT was run to confirm bit identical results. For global applications, no new baseline was created and results were bit identical.
Dependencies
fv3atm,ufs-weather-model
ufs-community/ufs-weather-model#594
NOAA-EMC/ufsatm#327