Updating nemelist templates and configuration files to have consistent format as the global workflow; Update CDEPS (was #1741)#1699
Conversation
|
@SadeghTabas-NOAA The changes to the run sequence in the cpld_noaero test are not correct. That test runs the waves in the fast loop; it looks like you've made it match the slow loop case (_outwav). |
|
@DeniseWorthen This is one of the incremental updates to match the RT configurations with the global workflow. The global workflow now has wave in slow loop. @aerorahul @JessicaMeixner-NOAA please confirm if wave needs to be in slow loop for the coupled tests. |
|
@junwang-noaa That will be a major change in the current regression tests for the coupled model. |
|
Jenkins-ci logs attached. ORTs all passed. |
|
Sorry I closed the PR accidentally. I reopened it. I just wanted to say that I think the PR1741 was reviewed yesterday and the reviews gone once the branch updated. Sorry for the inconvenience. |
|
@SadeghTabas-NOAA I think everything's ok. Review was requested on the 1741 sub-pr, but has not been provided yet. |
|
@BrianCurtis-NOAA I know we talked previously but just wanted to make note of it here. Once the review/approval is given on the CDEPS sub-pr #55 . We can begin testing of this merged PR. |
|
Ok, most of the tests are finished. I'll attempt to add Orion logs later this evening, assuming I'm able to login. |
|
Testing is now complete on this PR. |
|
The CDEPS subcomponent PR #55 has been merged. It doesn't look like any submodules pointers need to be updated or gitmodules reverted in this combined PR, so I'll go ahead to send out final reviews. |
|
@SadeghTabas-NOAA @zach1221 correct cdeps hash is NOAA-EMC/CDEPS@2aa6bfb. Can we make sure? |
|
@SadeghTabas-NOAA I don't think the hash is correct. |
|
@SadeghTabas-NOAA Can you update the CDEPS hash from fa0a925 to the correct hash of https://github.com/NOAA-EMC/CDEPS : 2aa6bfbb62ebeecd7da964b8074f6c3c41c7d1eb |
|
I updated the submodule pointer. Sorry for inconvenience. Thanks |
|
Thanks, @SadeghTabas-NOAA ! Resending reviews |
Description
The nemalist templates and configuration files (model_configure and nems.configure) used in the global RT tests will be cleaned up and updated to have consistent format as the global workflow. This goal is to remove the discrepancy between RT test runs and the global workflow runs.
Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
Subcomponents involved:
Combined with PR's (If Applicable):
Linked PR: #1741
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):