Skip to content

Updating nemelist templates and configuration files to have consistent format as the global workflow; Update CDEPS (was #1741)#1699

Merged
zach1221 merged 63 commits into
ufs-community:developfrom
sadeghitabas:name_list_update
May 25, 2023
Merged

Updating nemelist templates and configuration files to have consistent format as the global workflow; Update CDEPS (was #1741)#1699
zach1221 merged 63 commits into
ufs-community:developfrom
sadeghitabas:name_list_update

Conversation

@sadeghitabas
Copy link
Copy Markdown
Contributor

@sadeghitabas sadeghitabas commented Apr 6, 2023

Description

The nemalist templates and configuration files (model_configure and nems.configure) used in the global RT tests will be cleaned up and updated to have consistent format as the global workflow. This goal is to remove the discrepancy between RT test runs and the global workflow runs.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Linked PR: #1741

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@sadeghitabas sadeghitabas changed the title Name list update Updating nemelist templates and configuration files to have consistent format as the global workflow Apr 6, 2023
@sadeghitabas sadeghitabas marked this pull request as draft April 6, 2023 02:19
@sadeghitabas sadeghitabas self-assigned this Apr 6, 2023
@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@SadeghTabas-NOAA The changes to the run sequence in the cpld_noaero test are not correct. That test runs the waves in the fast loop; it looks like you've made it match the slow loop case (_outwav).

@junwang-noaa
Copy link
Copy Markdown
Collaborator

@DeniseWorthen This is one of the incremental updates to match the RT configurations with the global workflow. The global workflow now has wave in slow loop. @aerorahul @JessicaMeixner-NOAA please confirm if wave needs to be in slow loop for the coupled tests.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@junwang-noaa That will be a major change in the current regression tests for the coupled model.

@zach1221
Copy link
Copy Markdown
Collaborator

Jenkins-ci logs attached. ORTs all passed.
ufs-weather-model » ort-docker-pipeline » PR-1699 #2 Console [Jenkins].pdf

@sadeghitabas
Copy link
Copy Markdown
Contributor Author

Sorry I closed the PR accidentally. I reopened it. I just wanted to say that I think the PR1741 was reviewed yesterday and the reviews gone once the branch updated. Sorry for the inconvenience.

@zach1221
Copy link
Copy Markdown
Collaborator

@SadeghTabas-NOAA I think everything's ok. Review was requested on the 1741 sub-pr, but has not been provided yet.

@zach1221
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA I know we talked previously but just wanted to make note of it here. Once the review/approval is given on the CDEPS sub-pr #55 . We can begin testing of this merged PR.

@zach1221
Copy link
Copy Markdown
Collaborator

Ok, most of the tests are finished. I'll attempt to add Orion logs later this evening, assuming I'm able to login.

@zach1221
Copy link
Copy Markdown
Collaborator

Testing is now complete on this PR.

@zach1221
Copy link
Copy Markdown
Collaborator

The CDEPS subcomponent PR #55 has been merged. It doesn't look like any submodules pointers need to be updated or gitmodules reverted in this combined PR, so I'll go ahead to send out final reviews.

DeniseWorthen
DeniseWorthen previously approved these changes May 25, 2023
@jkbk2004
Copy link
Copy Markdown
Collaborator

@SadeghTabas-NOAA @zach1221 correct cdeps hash is NOAA-EMC/CDEPS@2aa6bfb. Can we make sure?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@SadeghTabas-NOAA I don't think the hash is correct.

@zach1221
Copy link
Copy Markdown
Collaborator

@SadeghTabas-NOAA Can you update the CDEPS hash from fa0a925 to the correct hash of https://github.com/NOAA-EMC/CDEPS : 2aa6bfbb62ebeecd7da964b8074f6c3c41c7d1eb

@sadeghitabas
Copy link
Copy Markdown
Contributor Author

I updated the submodule pointer. Sorry for inconvenience. Thanks

@zach1221
Copy link
Copy Markdown
Collaborator

Thanks, @SadeghTabas-NOAA ! Resending reviews

Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating the global tests namelist and configuration file format

9 participants