ensure exported zbot field is non-negative for coupling#294
Conversation
merge to latest develop
The HAFS related developments for the write_grid_component (#10)
change ifmin to zero at fh00 for inline POST (#14)
merge to latest develop
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (NOAA-EMC#30)
GFSv16 netcdf post ficein cpl (NOAA-EMC#48)
Regain bit-for-bit identical results between IPD and CCPP for coupled…
Merge NCAR:dtc/develop into develop 2020/04/14 (NOAA-EMC#98)
Port to Orion (NOAA-EMC#102)
Remove dynamic CCPP build (NOAA-EMC#103)
|
Converting this to a draft PR in expectation that a correct solution to the root issue will be found prior to the PR for updating the IC is ready for commit. |
|
The issue is now fixed using dycore PR GFDL_atmos_cubed_sphere PR 102 |
|
There are two extra file changes shown which will be resolved after PR #297 is merged. |
junwang-noaa
left a comment
There was a problem hiding this comment.
I will approve after the #297 is committed
|
Since dycore PR102 had been reviewed by Henry, Lucas and Rusty etc and they all approved, I have no other comments to this PR. Jun can approval will be sufficient. |
* add suite_FV3_GFS_v16_coupled_noahmp.xml and suite_FV3_GFS_v16_coupled_nsstNoahmp.xml suites * remove 'x' permissions on suite_FV3_GFS_v15p2_couplednsst.xml
|
@junwang-noaa In the email chain regarding this issue, there seems to be a proposed modification of the fix? I am unsure whether the code is good to be committed as is or if further modifications are going to be made. |
|
@HelinWei-NOAA the NoahMP ccpp suite files for coupled model are added |
Description
Ensures non-negative zbot and pbot for export to the coupled model. See dycore PR 102 for details
Issue(s) addressed
Testing