Skip to content

ensure exported zbot field is non-negative for coupling#294

Merged
junwang-noaa merged 65 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/noneg_zbot_export
May 13, 2021
Merged

ensure exported zbot field is non-negative for coupling#294
junwang-noaa merged 65 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/noneg_zbot_export

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 29, 2021

Description

Ensures non-negative zbot and pbot for export to the coupled model. See dycore PR 102 for details

Issue(s) addressed

Testing

DeniseWorthen and others added 30 commits November 18, 2019 11:11
The HAFS related developments for the write_grid_component (#10)
change ifmin to zero at fh00 for inline POST (#14)
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (NOAA-EMC#30)
GFSv16 netcdf post ficein cpl (NOAA-EMC#48)
Regain bit-for-bit identical results between IPD and CCPP for coupled…
Merge NCAR:dtc/develop into develop 2020/04/14 (NOAA-EMC#98)
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

Converting this to a draft PR in expectation that a correct solution to the root issue will be found prior to the PR for updating the IC is ready for commit.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented May 10, 2021

The issue is now fixed using dycore PR GFDL_atmos_cubed_sphere PR 102

@DeniseWorthen DeniseWorthen reopened this May 10, 2021
@DeniseWorthen DeniseWorthen marked this pull request as ready for review May 10, 2021 20:12
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

There are two extra file changes shown which will be resolved after PR #297 is merged.

Copy link
Copy Markdown
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve after the #297 is committed

@yangfanglin
Copy link
Copy Markdown
Collaborator

Since dycore PR102 had been reviewed by Henry, Lucas and Rusty etc and they all approved, I have no other comments to this PR. Jun can approval will be sufficient.

* add suite_FV3_GFS_v16_coupled_noahmp.xml and suite_FV3_GFS_v16_coupled_nsstNoahmp.xml suites
* remove 'x' permissions on suite_FV3_GFS_v15p2_couplednsst.xml
@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented May 12, 2021

@junwang-noaa In the email chain regarding this issue, there seems to be a proposed modification of the fix? I am unsure whether the code is good to be committed as is or if further modifications are going to be made.

@junwang-noaa
Copy link
Copy Markdown
Collaborator

@HelinWei-NOAA the NoahMP ccpp suite files for coupled model are added

Copy link
Copy Markdown
Collaborator

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@junwang-noaa junwang-noaa merged commit 0215d0f into NOAA-EMC:develop May 13, 2021
@DeniseWorthen DeniseWorthen deleted the feature/noneg_zbot_export branch October 9, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"inst_height_lowest" field can have negative values exported to ICE when running coupled.

6 participants