Bugfix for nest namelists, includes "feature/update mom6 20210402"#488
Merged
junwang-noaa merged 41 commits intoApr 12, 2021
Conversation
*allow topo-edits to change the land mask when run with CICE6 in ufs
…similar to other platforms
This was referenced Mar 27, 2021
climbfuji
changed the title
…r-model into bugfix_nests_namelist_and_unnecessary_recompiling
Collaborator
|
@climbfuji <https://github.com/climbfuji> Thanks for confirming the
successful run of CI tests.
…On Fri, Apr 9, 2021 at 8:25 PM Dom Heinzeller ***@***.***> wrote:
@jiandewang <https://github.com/jiandewang> regression tests passed
against existing baselines on hera.intel and hera.gnu, logs updated in the
PR. I kicked off the ci tests, once those are done I will add the auto-rt
labels for the other platforms and run on Cheyenne. Please run rt.sh on the
wcoss platforms (on Monday, no rush). Thanks!
I wanted to clarify how to run the tests for the correct branch. On each
of the wcoss systems, please do
git checkout -b bugfix_nests_namelist_and_unnecessary_recompiling --recursive https://github.com/climbfuji/ufs-weather-model
to check out the correct code.
@junwang-noaa <https://github.com/junwang-noaa> @MinsukJi-NOAA
<https://github.com/MinsukJi-NOAA> CI tests passed for commit 2126475
<2126475>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#488 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKLG4LNDXRWEF6L4VLTH6LHZANCNFSM4Z4NBJCQ>
.
|
Collaborator
|
@climbfuji wcoss runs finished successfully, see RT log on HERA: /scratch2/NCEPDEV/climate/Jiande.Wang/For-others/For-Dom. Let me know when it's the time for me to ask for reviewers to approve the MOM6 PR and do the merging. |
…ttps://github.com/climbfuji/ufs-weather-model into bugfix_nests_namelist_and_unnecessary_recompiling
Collaborator
Author
|
Regression tests passed on all platforms, ci tests passed as well. @jiandewang the mom6 PR NOAA-EMC/MOM6#65 can be merged. @junwang-noaa the fv3atm PR NOAA-EMC/ufsatm#263 can be merged. Thanks! |
Collaborator
|
@climbfuji Could you edit the PR title to add that it includes the MOM6 update? |
climbfuji
changed the title
Collaborator
MOM6 PR has been merged to dev/emc |
Collaborator
|
FV3 PR was merged.
…On Mon, Apr 12, 2021 at 9:06 AM jiandewang ***@***.***> wrote:
Regression tests passed on all platforms, ci tests passed as well.
@jiandewang <https://github.com/jiandewang> the mom6 PR NOAA-EMC/MOM6#65
<NOAA-EMC/MOM6#65> can be merged. @junwang-noaa
<https://github.com/junwang-noaa> the fv3atm PR NOAA-EMC/ufsatm#263
<NOAA-EMC/ufsatm#263> can be merged. Thanks!
MOM6 PR has been merged to dev/emc
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#488 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TNP3YJP6DNSKMT2Q4LTILV5XANCNFSM4Z4NBJCQ>
.
|
DeniseWorthen
approved these changes
Apr 12, 2021
Collaborator
DeniseWorthen
left a comment
DeniseWorthen
left a comment
There was a problem hiding this comment.
Looks OK and ready to merge after submodules are reverted.
climbfuji
added
the
Ready for Commit Queue
Collaborator
Author
|
Submodule pointers have been updated, I verified them to be correct. |
junwang-noaa
approved these changes
Apr 12, 2021
jiandewang
approved these changes
Apr 12, 2021
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
This PR
atmos_model_nmlfor nests (see associated PRs for more information)Issue(s) addressed
Testing
No answer changes expected for the regression tests. No change to baselines, no new input data. Regression tests passed on:
Dependencies
NOAA-GFDL/GFDL_atmos_cubed_sphere#86
NOAA-EMC/ufsatm#263
#488